{"id":22423,"url":"https://patchwork.libcamera.org/api/1.1/patches/22423/?format=json","web_url":"https://patchwork.libcamera.org/patch/22423/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241219211010.103310-6-mzamazal@redhat.com>","date":"2024-12-19T21:10:10","name":"[v2,5/5] ipa: simple: Report contrast in metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f741ff6b7687f576d1dc5d7736d1f2e28837fb95","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22423/mbox/","series":[{"id":4920,"url":"https://patchwork.libcamera.org/api/1.1/series/4920/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4920","date":"2024-12-19T21:10:05","name":"ipa: simple: Introduce metadata reporting","version":2,"mbox":"https://patchwork.libcamera.org/series/4920/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22423/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22423/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82791C3312\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Dec 2024 21:10:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8612F6848D;\n\tThu, 19 Dec 2024 22:10:41 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5AAB68480\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Dec 2024 22:10:37 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-670-ksjzk513PEKy3GDluAmUhg-1;\n\tThu, 19 Dec 2024 16:10:34 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8357E1956077; Thu, 19 Dec 2024 21:10:33 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.37])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D138030044C1; Thu, 19 Dec 2024 21:10:31 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"e2JfuUZj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1734642637;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tQM+GajCGK8QL/RdzTuLWiiBSm8L6ggAWVvPgB+kSeg=;\n\tb=e2JfuUZjhVZKJnMUAiKKCTqqsS9+IRfn3wTjZDsFl9PpmdvA3EgEz7G4Rbzm3RPT1qYLRt\n\tt7TqxwpnOVVlZyzwndHWEG8FNESHk9KnvIaz5Y9y7gwTrgFjVJABhkdX3+iLRjpYzA4I1h\n\tVE3yqxHQr6H2nSBqs/t8ckabyZgFp40=","X-MC-Unique":"ksjzk513PEKy3GDluAmUhg-1","X-Mimecast-MFC-AGG-ID":"ksjzk513PEKy3GDluAmUhg","From":"Milan Zamazal <mzamazal@redhat.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","Subject":"[PATCH v2 5/5] ipa: simple: Report contrast in metadata","Date":"Thu, 19 Dec 2024 22:10:10 +0100","Message-ID":"<20241219211010.103310-6-mzamazal@redhat.com>","In-Reply-To":"<20241219211010.103310-1-mzamazal@redhat.com>","References":"<20241219211010.103310-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Z9r3kUqiWdm3m2v2j95ox1hcPWf5PyvJoJplfYgu8wY_1734642633","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Provide the requested contrast value, if any, in the metadata to add to\nthe completed requests.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/lut.cpp | 11 +++++++++++\n src/ipa/simple/algorithms/lut.h   |  5 +++++\n 2 files changed, 16 insertions(+)","diff":"diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 0ba2391f..31208bfe 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -116,6 +116,17 @@ void Lut::prepare(IPAContext &context,\n \t}\n }\n \n+void Lut::process(IPAContext &context,\n+\t\t  [[maybe_unused]] const uint32_t frame,\n+\t\t  [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t  [[maybe_unused]] const SwIspStats *stats,\n+\t\t  ControlList &metadata)\n+{\n+\tconst auto contrast = context.activeState.knobs.contrast;\n+\tif (contrast)\n+\t\tmetadata.set(controls::Contrast, contrast.value());\n+}\n+\n REGISTER_IPA_ALGORITHM(Lut, \"Lut\")\n \n } /* namespace ipa::soft::algorithms */\ndiff --git a/src/ipa/simple/algorithms/lut.h b/src/ipa/simple/algorithms/lut.h\nindex 889f864b..ab4e1094 100644\n--- a/src/ipa/simple/algorithms/lut.h\n+++ b/src/ipa/simple/algorithms/lut.h\n@@ -30,6 +30,11 @@ public:\n \t\t     const uint32_t frame,\n \t\t     IPAFrameContext &frameContext,\n \t\t     DebayerParams *params) override;\n+\tvoid process(IPAContext &context,\n+\t\t     const uint32_t frame,\n+\t\t     IPAFrameContext &frameContext,\n+\t\t     const SwIspStats *stats,\n+\t\t     ControlList &metadata) override;\n \n private:\n \tvoid updateGammaTable(IPAContext &context);\n","prefixes":["v2","5/5"]}