{"id":22358,"url":"https://patchwork.libcamera.org/api/1.1/patches/22358/?format=json","web_url":"https://patchwork.libcamera.org/patch/22358/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241216154124.203650-13-stefan.klug@ideasonboard.com>","date":"2024-12-16T15:40:52","name":"[v4,12/20] pipeline: rkisp1: Add ScalerMaximumCrop property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fa90a63ddea01f2ed126e9f5a05db50834ce0b0e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22358/mbox/","series":[{"id":4896,"url":"https://patchwork.libcamera.org/api/1.1/series/4896/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4896","date":"2024-12-16T15:40:40","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":4,"mbox":"https://patchwork.libcamera.org/series/4896/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22358/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22358/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48A12C32F6\n\tfor ;\n\tMon, 16 Dec 2024 15:42:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFCDE67F91;\n\tMon, 16 Dec 2024 16:42:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9117867F89\n\tfor ;\n\tMon, 16 Dec 2024 16:42:19 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bfdf:3a3c:e45:66e3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 016F6675;\n\tMon, 16 Dec 2024 16:41:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ge+rPnnC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734363703;\n\tbh=KS+swCWwgQ+GxyE65Yd6uWSlQ4m0+yF3TC/c8mw9RJk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ge+rPnnC18gGktUrmmGH+4MGl/6KU3yLh75/NKXWyP70Np+B+90ZHT3b1mD6Tq/GO\n\t1UkU447YGbSIcAVzQmY6ehpe+77CFdmAUiMjrGWNe2+ZufjPMYQLFFb9zMlK0jcgWq\n\tldnwNWCG4VOClvHUny+JZiHedWwR4hcuWuIKz9dA=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ,\n\tJacopo Mondi ","Subject":"[PATCH v4 12/20] pipeline: rkisp1: Add ScalerMaximumCrop property","Date":"Mon, 16 Dec 2024 16:40:52 +0100","Message-ID":"<20241216154124.203650-13-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\nvalue. Add it to the rkisp1.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \nReviewed-by: Jacopo Mondi \n\n---\n\nChanges in v4:\n- Collected tags\n\nChanges in v2:\n- Moved one hunk to the correct patch 6/7\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ef4aa38478f5..abe2dce0024d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -24,6 +24,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -1248,6 +1249,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n \t\t\t\t\t\t\t scalerMaxCrop_,\n \t\t\t\t\t\t\t scalerMaxCrop_);\n+\t\tdata->properties_.set(properties::ScalerCropMaximum, scalerMaxCrop_);\n \t\tactiveCrop_ = scalerMaxCrop_;\n \t}\n \n","prefixes":["v4","12/20"]}