{"id":22352,"url":"https://patchwork.libcamera.org/api/1.1/patches/22352/?format=json","web_url":"https://patchwork.libcamera.org/patch/22352/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241216154124.203650-7-stefan.klug@ideasonboard.com>","date":"2024-12-16T15:40:46","name":"[v4,06/20] libcamera: converter_v4l2_m2m: Add missing override specifier","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e358c0c07c171d08df9ae5c4cb73be47d235da3c","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22352/mbox/","series":[{"id":4896,"url":"https://patchwork.libcamera.org/api/1.1/series/4896/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4896","date":"2024-12-16T15:40:40","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":4,"mbox":"https://patchwork.libcamera.org/series/4896/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22352/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22352/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CBC1C32F6\n\tfor ;\n\tMon, 16 Dec 2024 15:42:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 736FB67F81;\n\tMon, 16 Dec 2024 16:42:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E83B67F79\n\tfor ;\n\tMon, 16 Dec 2024 16:42:03 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bfdf:3a3c:e45:66e3])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42F7B675;\n\tMon, 16 Dec 2024 16:41:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iwrSbliX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734363687;\n\tbh=OHbDWZzgC0bwMfQ1fIsCR9z8ra9VisRmR4TaKweDCr8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iwrSbliXCcA/kodFCI/R7xt2RxtIZpjZ+Hhvlui5v7AsqswfT9Ys61T1awE2tutkB\n\t2ogWb4qfFrXxda2cyQuFPQMMkpOx7DFpg3s78mSbrFZMrzh/jjd1A5UwA1EtrKpsfe\n\t8A2uG1yecKr5Q+2MRgEcWH6dAu/th2HDKnHuAlOg=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v4 06/20] libcamera: converter_v4l2_m2m: Add missing override\n\tspecifier","Date":"Mon, 16 Dec 2024 16:40:46 +0100","Message-ID":"<20241216154124.203650-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","References":"<20241216154124.203650-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation to adding new functions and overrides to the\nV4L2M2MDevice class add an override specifier to all overridden\nfunctions in the class. This prevents -Winconsistent-missing-override\nwarnings.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v4:\n- Added this patch\n---\n .../internal/converter/converter_v4l2_m2m.h | 25 ++++++++++---------\n 1 file changed, 13 insertions(+), 12 deletions(-)","diff":"diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\nindex 0bc0d053e2c4..9b8e43ff0b91 100644\n--- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n+++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n@@ -38,28 +38,29 @@ class V4L2M2MConverter : public Converter\n public:\n \tV4L2M2MConverter(MediaDevice *media);\n \n-\tint loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; }\n-\tbool isValid() const { return m2m_ != nullptr; }\n+\tint loadConfiguration([[maybe_unused]] const std::string &filename) override { return 0; }\n+\tbool isValid() const override { return m2m_ != nullptr; }\n \n-\tstd::vector formats(PixelFormat input);\n-\tSizeRange sizes(const Size &input);\n+\tstd::vector formats(PixelFormat input) override;\n+\tSizeRange sizes(const Size &input) override;\n \n \tstd::tuple\n-\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size);\n+\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size) override;\n \n \tint configure(const StreamConfiguration &inputCfg,\n-\t\t const std::vector> &outputCfg);\n+\t\t const std::vector>\n+\t\t &outputCfg) override;\n \tint exportBuffers(const Stream *stream, unsigned int count,\n-\t\t\t std::vector> *buffers);\n+\t\t\t std::vector> *buffers) override;\n \n-\tint start();\n-\tvoid stop();\n+\tint start() override;\n+\tvoid stop() override;\n \n \tint queueBuffers(FrameBuffer *input,\n-\t\t\t const std::map &outputs);\n+\t\t\t const std::map &outputs) override;\n \n-\tint setInputCrop(const Stream *stream, Rectangle *rect);\n-\tstd::pair inputCropBounds(const Stream *stream);\n+\tint setInputCrop(const Stream *stream, Rectangle *rect) override;\n+\tstd::pair inputCropBounds(const Stream *stream) override;\n \n private:\n \tclass V4L2M2MStream : protected Loggable\n","prefixes":["v4","06/20"]}