{"id":22315,"url":"https://patchwork.libcamera.org/api/1.1/patches/22315/?format=json","web_url":"https://patchwork.libcamera.org/patch/22315/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241215192354.824108-1-pobrn@protonmail.com>","date":"2024-12-15T19:23:57","name":"[RFC,v1] meson: Convert `v4l2` into a feature option","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4d065d531b4d8e802e03570deae1af5fc293455c","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/1.1/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22315/mbox/","series":[{"id":4884,"url":"https://patchwork.libcamera.org/api/1.1/series/4884/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4884","date":"2024-12-15T19:23:57","name":"[RFC,v1] meson: Convert `v4l2` into a feature option","version":1,"mbox":"https://patchwork.libcamera.org/series/4884/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22315/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22315/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1DCEC32F5\n\tfor ;\n\tSun, 15 Dec 2024 19:24:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9482467F11;\n\tSun, 15 Dec 2024 20:24:07 +0100 (CET)","from mail-10628.protonmail.ch (mail-10628.protonmail.ch\n\t[79.135.106.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDBB667EEE\n\tfor ;\n\tSun, 15 Dec 2024 20:24:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"jUR3sbWl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734290643; x=1734549843;\n\tbh=XHA5l8iLhtlyKSsQfCRV3v+lxpOBR4ArLdHo5k549OQ=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=jUR3sbWlvmD3gFFiCuVRrlvhlJ0f0sCqQKn0fgNVsYPXP9E957iL1s7DayojX4HCP\n\tlxvxdcyXNBgi+L2ddZ5JT4lkNZtwda9Hwkrf6XfSnvvBMw2q3shK+UvOxEQqV5ZIvR\n\t0140OVIuTFlAUNW6wJHbb4q2DkzEAkFfM3795WTyUeLqb1wTu8XAJ4MVh7nAsKbouR\n\t7X8XcsQ/pMxDkOaDt8MSZ8gNQtVFvf6qAkx9u3dEQr9/NWWfrus0VtDUqCQN4eXmI0\n\tKV7YMJ7ztxxF002YPNf29jBgW4d7XHBx+YH7A65rpZAHpOJ1iJ6V/0/H/i4qMumai0\n\tnCx5jv2yDJjeA==","Date":"Sun, 15 Dec 2024 19:23:57 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[RFC PATCH v1] meson: Convert `v4l2` into a feature option","Message-ID":"<20241215192354.824108-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"c2c390dd00e65be8353317798e45164e0ef93e82","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The v4l2 compatibility layer does not have external dependencies,\nthe usual benefits of a feature option do not apply. The main\nmotivation behind this change is making use of the `auto_features`\nmeson option that can change all feature options set to \"auto\"\nby default to the desired value.\n\nThis can be useful for two reasons: (1) using auto_features=disabled\nand then building up the list of features that are desired in the\nparticular build; (2) using auto_features=enabled to achieve\n(usually) more testing and compilation coverage.\n\nSigned-off-by: Barnabás Pőcze \n---\n meson_options.txt | 4 ++--\n src/v4l2/meson.build | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/meson_options.txt b/meson_options.txt\nindex c91cd241a..08e224561 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -84,6 +84,6 @@ option('udev',\n description : 'Enable udev support for hotplug')\n \n option('v4l2',\n- type : 'boolean',\n- value : false,\n+ type : 'feature',\n+ value : 'auto',\n description : 'Compile the V4L2 compatibility layer')\ndiff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex 58f53bf3d..e4daf8ae7 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -1,6 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-if not get_option('v4l2')\n+if not get_option('v4l2').allowed()\n v4l2_enabled = false\n subdir_done()\n endif\n","prefixes":["RFC","v1"]}