{"id":22257,"url":"https://patchwork.libcamera.org/api/1.1/patches/22257/?format=json","web_url":"https://patchwork.libcamera.org/patch/22257/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241209104727.520859-1-naush@raspberrypi.com>","date":"2024-12-09T10:47:23","name":"ipa: rpi: Fix wrong frame integration difference value for OV9281","commit_ref":"229667606e4d30e03d530341baf1ee528e7f2e95","pull_url":null,"state":"accepted","archived":false,"hash":"d3bbd54b49f0d2df95caf18e0ce0d9b2ed86ff49","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22257/mbox/","series":[{"id":4865,"url":"https://patchwork.libcamera.org/api/1.1/series/4865/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4865","date":"2024-12-09T10:47:23","name":"ipa: rpi: Fix wrong frame integration difference value for OV9281","version":1,"mbox":"https://patchwork.libcamera.org/series/4865/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22257/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22257/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AE2FBD80A\n\tfor ;\n\tMon, 9 Dec 2024 10:47:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 947F667E5F;\n\tMon, 9 Dec 2024 11:47:35 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D442E618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:47:33 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-434a7cef2e3so3551645e9.1\n\tfor ;\n\tMon, 09 Dec 2024 02:47:33 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-434fb066874sm20723345e9.32.2024.12.09.02.47.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Dec 2024 02:47:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"H/vaJExf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733741253; x=1734346053;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=w5gTjakyt0xnKmfCUBfHdf3arb8cxmqirdSc9BfMuag=;\n\tb=H/vaJExfQFO+E2QmOIki470ru9NRe2Pn8xfuEc8dwYAM9k/0FdBYgm5EiWShkLyI7T\n\tua6FNnLmk0JTapWTjzEjaK58wguWvXDO7+oP83a/n0LdiowRuKIQVLuWQe9hNdTnzUUo\n\tQylzZGoWDrTnWectKFifSA8Z/3Pz0g/2HFvkuwEJanBAZNo9/5HCNvQpebcCnMp+9xzF\n\t8zaajJtgjfLYfKE9ydHM3xNToxjOHb8P4jqXezxTMr/1oO9rbkQ80ltg7Hb7gmzvbDgt\n\tcfuNjOFDDxLs6YkmGswjTuuiDPszlNDpQy9P9UJVOszQiotQconbG//gXZcbFWMDR5o+\n\t4FyA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733741253; x=1734346053;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=w5gTjakyt0xnKmfCUBfHdf3arb8cxmqirdSc9BfMuag=;\n\tb=bsmEXC0C2wjtEtuzwBdQA1FDAyC4gQnVkRcp5VfIFghXRqXtVEwC/4gEtzMSNrp+zP\n\tux/ydz3+hk+51S2N10PU7r0LVIgNdBveRzYwNYIeWROsFawByWY56D+NQ7rQ832UMyWU\n\tXJhCtbwQ+/Alp10z1z0q9aF0FYIVw8qzYtH0WlFw2wUY/CuMnUHxOJtHtEODiugptEaE\n\tPS/wT7cGaa57LyTo8H5/2KaUWsUzWj/4l2l1h/KTR+sg0nWXivHAKHwC4QWDONjMUDh4\n\tK6Nch40q93I9sQ7+6L/MkOHoB7FtZxKB+tMv2qz/EI/FxLsd16ZL38JIwu31cLpLWc15\n\tyspg==","X-Gm-Message-State":"AOJu0YxySMiBGypgUgsn+Ybu4P6VmtAWB57P5xOhhmHu2VcHXU1/Y0xT\n\tbumTmaBtlXikH7VQG/dTZF66xd1mHuuh5hNV/rDk4AXYJKmIsCK5kfbmIPFPSqV1bXK3Tr5sLMP\n\tI","X-Gm-Gg":"ASbGncs/gV0mcYjij2TvpEUrnCTbQZumPl07pni9He+OuF7cKHPL5ZXMBhmIyoFpdix\n\taSXGYgHBwPwPB+weE7mwL6iDUP/JsrLOxfSMFc473hr4jCseWgRDLXPXnq9B9Y/B24BBVX/lcEf\n\tMXw7TxIxj968C/oCO55jg7UWJx1mF8ko8CeG2dr91ila2qrclFgpEFSJpcYB0oxUsrXen5ppws0\n\tjJ5fH4HF1mL781B9Wx0mPEnzTIrIg0ljKtU4VZ8O6XMxkJrZsR7INuQdMK3W3An3h3w8w==","X-Google-Smtp-Source":"AGHT+IFj3FBXgWuQOPtw/cQ5E+RHhplvrYEHS6m1ZzLPcjLw5ncjrI9Fd2zyonk+laPfhbBpb1RQzw==","X-Received":"by 2002:a05:600c:3c97:b0:42c:bfd6:9d2f with SMTP id\n\t5b1f17b1804b1-434ddea311bmr38149875e9.1.1733741253083; \n\tMon, 09 Dec 2024 02:47:33 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"dave.stevenson@raspberrypi.com,\n\tNaushir Patuck ","Subject":"[PATCH] ipa: rpi: Fix wrong frame integration difference value for\n\tOV9281","Date":"Mon, 9 Dec 2024 10:47:23 +0000","Message-ID":"<20241209104727.520859-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The frameIntegrationDiff value should be 25, otherwise we see invalid\nframes when integration times are set to large values.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\nindex a65c8ac08c1c..96f7fff499f5 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n@@ -25,7 +25,7 @@ private:\n \t * Smallest difference between the frame length and integration time,\n \t * in units of lines.\n \t */\n-\tstatic constexpr int frameIntegrationDiff = 4;\n+\tstatic constexpr int frameIntegrationDiff = 25;\n };\n \n /*\n","prefixes":[]}