{"id":22235,"url":"https://patchwork.libcamera.org/api/1.1/patches/22235/?format=json","web_url":"https://patchwork.libcamera.org/patch/22235/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206162230.97619-1-jacopo.mondi@ideasonboard.com>","date":"2024-12-06T16:22:29","name":"[v2] libcamera: stream: Add operator<<(StreamConfiguration)","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3d62aa0e3b3a0cd560cd2429cde4ad1b3e729efb","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22235/mbox/","series":[{"id":4859,"url":"https://patchwork.libcamera.org/api/1.1/series/4859/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4859","date":"2024-12-06T16:22:29","name":"[v2] libcamera: stream: Add operator<<(StreamConfiguration)","version":2,"mbox":"https://patchwork.libcamera.org/series/4859/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22235/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22235/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCBE1BE173\n\tfor ;\n\tFri, 6 Dec 2024 16:22:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 114B867E1F;\n\tFri, 6 Dec 2024 17:22:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E8BE618B3\n\tfor ;\n\tFri, 6 Dec 2024 17:22:38 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B615641;\n\tFri, 6 Dec 2024 17:22:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YvOJ6UuJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733502128;\n\tbh=ac0ikermms3mqQBuukq11Cn/a7MveYiZuQx8G95R20A=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YvOJ6UuJzDxKYh1bovcBo0tSUm/uJiBcgaBcLXI1O3yUTx4NWP00kavJIz8yW92F4\n\tfbMnu9c/l3zFB71gbe6QnchDVQzziOcTTxoZKjXQrlGZaYEdQ4Uo8HRBgVhIegjMSO\n\tP+X2RP+yl7etycvnExpeDmxDTEsDEx8qGSnAvXz8=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[PATCH v2] libcamera: stream: Add operator<<(StreamConfiguration)","Date":"Fri, 6 Dec 2024 17:22:29 +0100","Message-ID":"<20241206162230.97619-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.47.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The StreamConfiguration class only implements toString() but doesn't\noffer an overload of operator<<() which is more convenient to use.\n\nAdd an overload for operator<<(StreamConfiguration) and re-implement\nStreamConfiguration::toString() on top of it.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/stream.h | 2 ++\n src/libcamera/stream.cpp | 18 +++++++++++++++++-\n 2 files changed, 19 insertions(+), 1 deletion(-)\n\n--\n2.47.1","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 071b71698acb..ea228aea7d56 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -61,6 +61,8 @@ private:\n \tStreamFormats formats_;\n };\n\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n+\n enum class StreamRole {\n \tRaw,\n \tStillCapture,\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 1f75dbbc5b64..63aa5a027295 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -392,7 +392,23 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n */\n std::string StreamConfiguration::toString() const\n {\n-\treturn size.toString() + \"-\" + pixelFormat.toString();\n+\tstd::stringstream ss;\n+\tss << *this;\n+\n+\treturn ss.str();\n+}\n+\n+/**\n+ * \\brief Insert a text representation of a StreamConfiguration into an output\n+ * stream\n+ * \\param[in] out The output stream\n+ * \\param[in] cfg The StreamConfiguration\n+ * \\return The output stream \\a out\n+ */\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n+{\n+\tout << size.toString() + \"-\" + pixelFormat.toString();\n+\treturn out;\n }\n\n /**\n","prefixes":["v2"]}