{"id":22206,"url":"https://patchwork.libcamera.org/api/1.1/patches/22206/?format=json","web_url":"https://patchwork.libcamera.org/patch/22206/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206101344.767170-15-stefan.klug@ideasonboard.com>","date":"2024-12-06T10:13:36","name":"[v3,14/17] libcamera: rkisp1: make RkISP1CameraConfiguration a friend of the pipeline handler","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b4442c02ed86ef47d31dbbc5d8d4a4371436759d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/22206/mbox/","series":[{"id":4854,"url":"https://patchwork.libcamera.org/api/1.1/series/4854/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4854","date":"2024-12-06T10:13:22","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":3,"mbox":"https://patchwork.libcamera.org/series/4854/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22206/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22206/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 373FDBF415\n\tfor ;\n\tFri, 6 Dec 2024 10:14:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79AFE66158;\n\tFri, 6 Dec 2024 11:14:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71909618B2\n\tfor ;\n\tFri, 6 Dec 2024 11:14:28 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CF209FC;\n\tFri, 6 Dec 2024 11:13:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pz2O245V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733480039;\n\tbh=bjb3g6OquJEqFRgvtN/2g4Td9yLBkm5COZN0HzuAZSA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pz2O245VW4ZHQyHsgfcSJkv1LXgchGLvGsKVy0crs7HT6o4lYEkTKX7Jc48Zqp7XS\n\tO9N4ieo7YjZ58ztRJ6FgkfUAq5cOdFeHkWWNTXDRDMOjHHsXsSiib/PjsEU6I34nHt\n\tZiUQjjg+uEpJB+PlsLYGzF6wHmrT/df+dYgRQGBs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v3 14/17] libcamera: rkisp1: make RkISP1CameraConfiguration a\n\tfriend of the pipeline handler","Date":"Fri, 6 Dec 2024 11:13:36 +0100","Message-ID":"<20241206101344.767170-15-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For the validate() implementation, the RkISP1CameraConfiguration needs\naccess to dewarper related members of the PipelineHandlerRkISP1 object.\nAllow this access by adding const versions of the pipe accessors and\nmaking RkISP1CameraConfiguration a friend of PipelineHandlerRkISP1.\n\nSigned-off-by: Stefan Klug \n---\nChanges in v3:\n- Added this patch\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2c8d670768b1..c582e164670c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -98,6 +98,7 @@ public:\n \t}\n \n \tPipelineHandlerRkISP1 *pipe();\n+\tconst PipelineHandlerRkISP1 *pipe() const;\n \tint loadIPA(unsigned int hwRevision);\n \n \tStream mainPathStream_;\n@@ -176,6 +177,7 @@ private:\n \t}\n \n \tfriend RkISP1CameraData;\n+\tfriend RkISP1CameraConfiguration;\n \tfriend RkISP1Frames;\n \n \tint initLinks(Camera *camera, const CameraSensor *sensor,\n@@ -363,6 +365,11 @@ PipelineHandlerRkISP1 *RkISP1CameraData::pipe()\n \treturn static_cast(Camera::Private::pipe());\n }\n \n+const PipelineHandlerRkISP1 *RkISP1CameraData::pipe() const\n+{\n+\treturn static_cast(Camera::Private::pipe());\n+}\n+\n int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n {\n \tipa_ = IPAManager::createIPA(pipe(), 1, 1);\n","prefixes":["v3","14/17"]}