{"id":22202,"url":"https://patchwork.libcamera.org/api/1.1/patches/22202/?format=json","web_url":"https://patchwork.libcamera.org/patch/22202/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206101344.767170-11-stefan.klug@ideasonboard.com>","date":"2024-12-06T10:13:32","name":"[v3,10/17] libcamera: stream: Add operator<<(StreamConfiguration)","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1b426ec14ab554eb781857838b6fa83176aba251","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/22202/mbox/","series":[{"id":4854,"url":"https://patchwork.libcamera.org/api/1.1/series/4854/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4854","date":"2024-12-06T10:13:22","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":3,"mbox":"https://patchwork.libcamera.org/series/4854/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22202/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22202/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A3F7BF415\n\tfor ;\n\tFri, 6 Dec 2024 10:14:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AE6366152;\n\tFri, 6 Dec 2024 11:14:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4512266150\n\tfor ;\n\tFri, 6 Dec 2024 11:14:17 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E37BF74C;\n\tFri, 6 Dec 2024 11:13:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lIuSWZqN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733480028;\n\tbh=beaQDYwQKgfEBs+qNtBHHojP0XeZnjdVWoLcfmAqrfU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lIuSWZqNLUgTl0vRdfy+yEtW+y9IcLn0f7D4SjQpwoPxuOA0nqoLV/0qfW4yoshW7\n\tZk2S4VEMKAOb8oMXZPubAdbszgjcCKp3Y7syGZHCDKNHyjzje0VeYtHlO78QckEAWp\n\tMzBt54kcX9/lTlrFwd0LiJsPF5PoU/LT7gQCjnQo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","Subject":"[PATCH v3 10/17] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","Date":"Fri, 6 Dec 2024 11:13:32 +0100","Message-ID":"<20241206101344.767170-11-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nThe StreamConfiguration class only implmenets toString() but doesn't\noffer an overload of operator<<() which is convenient to use.\n\nAdd an overload for operator<<(StreamConfiguration) which is based on\nthe usage of StreamConfiguration::toString().\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/stream.h | 2 ++\n src/libcamera/stream.cpp | 13 +++++++++++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 071b71698acb..ea228aea7d56 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -61,6 +61,8 @@ private:\n \tStreamFormats formats_;\n };\n \n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n+\n enum class StreamRole {\n \tRaw,\n \tStillCapture,\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 1f75dbbc5b64..a093abf48c7c 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -395,6 +395,19 @@ std::string StreamConfiguration::toString() const\n \treturn size.toString() + \"-\" + pixelFormat.toString();\n }\n \n+/**\n+ * \\brief Insert a text representation of a StreamConfiguration into an output\n+ * stream\n+ * \\param[in] out The output stream\n+ * \\param[in] cfg The StreamConfiguration\n+ * \\return The output stream \\a out\n+ */\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n+{\n+\tout << cfg.toString();\n+\treturn out;\n+}\n+\n /**\n * \\enum StreamRole\n * \\brief Identify the role a stream is intended to play\n","prefixes":["v3","10/17"]}