{"id":22200,"url":"https://patchwork.libcamera.org/api/1.1/patches/22200/?format=json","web_url":"https://patchwork.libcamera.org/patch/22200/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206101344.767170-9-stefan.klug@ideasonboard.com>","date":"2024-12-06T10:13:30","name":"[v3,08/17] pipeline: rkisp1: Add ScalerMaximumCrop property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fa90a63ddea01f2ed126e9f5a05db50834ce0b0e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22200/mbox/","series":[{"id":4854,"url":"https://patchwork.libcamera.org/api/1.1/series/4854/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4854","date":"2024-12-06T10:13:22","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":3,"mbox":"https://patchwork.libcamera.org/series/4854/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22200/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22200/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3059EBF415\n\tfor ;\n\tFri, 6 Dec 2024 10:14:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7B666614D;\n\tFri, 6 Dec 2024 11:14:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F040466148\n\tfor ;\n\tFri, 6 Dec 2024 11:14:10 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 962A49FC;\n\tFri, 6 Dec 2024 11:13:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KF4pmQK1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733480021;\n\tbh=PeCrOych0B7QXQoGmkEvSCAKuUehc/eOSBzHYFIRX1M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KF4pmQK1XhINueHRcUUkh1z9RGdNFpupzQizHOadxv1i8DSYG704LmHRi3SOknlWP\n\tcaJ1+5P32LezoN3mwnj/HC7Jm107KTiOX+bh9ZO6prRnR0r9DPJX9oMm+KAyN3j6K3\n\tP73FMlfkn9KingSOBwykl37o/8kgsrjdZiEp8f0w=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ","Subject":"[PATCH v3 08/17] pipeline: rkisp1: Add ScalerMaximumCrop property","Date":"Fri, 6 Dec 2024 11:13:30 +0100","Message-ID":"<20241206101344.767170-9-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\nvalue. Add it to the rkisp1.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \n\n---\nChanges in v2:\n- Moved one hunk to the correct patch 6/7\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ad556ec85a2c..098c560ca5c8 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -24,6 +24,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -1245,6 +1246,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n \t\t\t\t\t\t\t scalerMaxCrop_,\n \t\t\t\t\t\t\t scalerMaxCrop_);\n+\t\tdata->properties_.set(properties::ScalerCropMaximum, scalerMaxCrop_);\n \t\tactiveCrop_ = scalerMaxCrop_;\n \t}\n \n","prefixes":["v3","08/17"]}