{"id":22181,"url":"https://patchwork.libcamera.org/api/1.1/patches/22181/?format=json","web_url":"https://patchwork.libcamera.org/patch/22181/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241205112314.26296-1-jacopo.mondi@ideasonboard.com>","date":"2024-12-05T11:23:13","name":"libcamera: stream: Add operator<<(StreamConfiguration)","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8fe8286845673eaf765b8cd74283423c4b7637c3","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22181/mbox/","series":[{"id":4850,"url":"https://patchwork.libcamera.org/api/1.1/series/4850/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4850","date":"2024-12-05T11:23:13","name":"libcamera: stream: Add operator<<(StreamConfiguration)","version":1,"mbox":"https://patchwork.libcamera.org/series/4850/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22181/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22181/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 544F6C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  5 Dec 2024 11:23:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07B4C6610A;\n\tThu,  5 Dec 2024 12:23:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA49F660F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  5 Dec 2024 12:23:24 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:6462:5de2:459e:1ee6:26ea:2d31])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EDCE22B3;\n\tThu,  5 Dec 2024 12:22:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jiwQYx58\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733397776;\n\tbh=hsn/3EkjUdCZ8EJo55JOiuMdpNRGXdtmWIBZohu8q6Y=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jiwQYx58NAb7NGMKbAmAu1RamPqmDAkvUWXvqUYwV7/ihDE8PziwiBpNoTNWlOvhB\n\tX57KmIu0XupA/mu+Z2BSaLo5jhihR90LN5/F+zx1YgXXYWUZGWr1tQe0xaaFnkk1ZC\n\tYvlGIHQbLVhUDgcRwjIdi0jH+izoFGZBuOgBVUXA=","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Subject":"[PATCH] libcamera: stream: Add operator<<(StreamConfiguration)","Date":"Thu,  5 Dec 2024 12:23:13 +0100","Message-ID":"<20241205112314.26296-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.47.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The StreamConfiguration class only implements toString() but doesn't\noffer an overload of operator<<() which is more convenient to use.\n\nAdd an overload for operator<<(StreamConfiguration) which is based on\nthe usage of StreamConfiguration::toString().\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/stream.h |  2 ++\n src/libcamera/stream.cpp   | 13 +++++++++++++\n 2 files changed, 15 insertions(+)\n\n--\n2.47.0","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 071b71698acb..ea228aea7d56 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -61,6 +61,8 @@ private:\n \tStreamFormats formats_;\n };\n\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n+\n enum class StreamRole {\n \tRaw,\n \tStillCapture,\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 1f75dbbc5b64..a093abf48c7c 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -395,6 +395,19 @@ std::string StreamConfiguration::toString() const\n \treturn size.toString() + \"-\" + pixelFormat.toString();\n }\n\n+/**\n+ * \\brief Insert a text representation of a StreamConfiguration into an output\n+ * stream\n+ * \\param[in] out The output stream\n+ * \\param[in] cfg The StreamConfiguration\n+ * \\return The output stream \\a out\n+ */\n+std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n+{\n+\tout << cfg.toString();\n+\treturn out;\n+}\n+\n /**\n  * \\enum StreamRole\n  * \\brief Identify the role a stream is intended to play\n","prefixes":[]}