{"id":22129,"url":"https://patchwork.libcamera.org/api/1.1/patches/22129/?format=json","web_url":"https://patchwork.libcamera.org/patch/22129/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241128125226.683249-3-mzamazal@redhat.com>","date":"2024-11-28T12:52:23","name":"[v5,2/4] ipa: ipu3: Add constructor to the IPA context","commit_ref":"c11e536ed2c379c0c3d24400fc9607c7135c02d2","pull_url":null,"state":"accepted","archived":false,"hash":"c75c0d5ba6058dd0a4abdb11b3a028e4e965ebdb","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22129/mbox/","series":[{"id":4831,"url":"https://patchwork.libcamera.org/api/1.1/series/4831/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4831","date":"2024-11-28T12:52:21","name":"Add contrast control to software ISP","version":5,"mbox":"https://patchwork.libcamera.org/series/4831/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22129/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22129/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 442C1BD78E\n\tfor ;\n\tThu, 28 Nov 2024 12:52:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 013BF65F78;\n\tThu, 28 Nov 2024 13:52:46 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0038765F56\n\tfor ;\n\tThu, 28 Nov 2024 13:52:43 +0100 (CET)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-362-OxsALaatNhS9soSPhSbiDQ-1;\n\tThu, 28 Nov 2024 07:52:39 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A42231944DD3; Thu, 28 Nov 2024 12:52:38 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.146])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id AA2AF1955D45; Thu, 28 Nov 2024 12:52:36 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FaXKehFN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1732798363;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=0tHm8A2qd3mgfgmgEqh1hPWpWr0yETjUehpM0UuI6cM=;\n\tb=FaXKehFNJWEp0pnNBusIG5EceP+b/OkUBifPUjnMEmT+5lGZ1GQVbyOf8msuq+tsV5ky7R\n\t3iaOFIdA9aNOuxft/u/sNqgT4UFqZtSeRZ5Q3lM8KVMs/pNfD8J+VwLcbKaDdjsLSXbjY9\n\ttvSFLh4/xXA24h+zXLoFRdsqtMKKFd8=","X-MC-Unique":"OxsALaatNhS9soSPhSbiDQ-1","X-Mimecast-MFC-AGG-ID":"OxsALaatNhS9soSPhSbiDQ","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tStefan Klug ","Subject":"[PATCH v5 2/4] ipa: ipu3: Add constructor to the IPA context","Date":"Thu, 28 Nov 2024 13:52:23 +0100","Message-ID":"<20241128125226.683249-3-mzamazal@redhat.com>","In-Reply-To":"<20241128125226.683249-1-mzamazal@redhat.com>","References":"<20241128125226.683249-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"5h1LI4CC4RaiccUs_ADE01gMvrar_LfNAae9nhgpX2I_1732798358","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's have a constructor that takes just the non-default argument,\nwithout the need to specify the defaults.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \n---\n src/ipa/ipu3/ipa_context.cpp | 4 ++++\n src/ipa/ipu3/ipa_context.h | 5 +++++\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex fe455e07..3b22f791 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -39,6 +39,10 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAContext\n * \\brief Global IPA context data shared between all algorithms\n *\n+ * \\fn IPAContext::IPAContext\n+ * \\brief Initialize the instance with the given number of frame contexts\n+ * \\param[in] frameContextSize Size of the frame context ring buffer\n+ *\n * \\var IPAContext::configuration\n * \\brief The IPA session configuration, immutable during the session\n *\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex 29f38b36..97fcf06c 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -84,6 +84,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 44c98cbf..1cae08bf 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -187,7 +187,7 @@ private:\n };\n \n IPAIPU3::IPAIPU3()\n-\t: context_({ {}, {}, { kMaxFrameContexts }, {} })\n+\t: context_(kMaxFrameContexts)\n {\n }\n \n","prefixes":["v5","2/4"]}