{"id":22080,"url":"https://patchwork.libcamera.org/api/1.1/patches/22080/?format=json","web_url":"https://patchwork.libcamera.org/patch/22080/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241125153003.3309066-5-paul.elder@ideasonboard.com>","date":"2024-11-25T15:30:03","name":"[4/4] apps: cam: Print control direction information","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"10894956b66759e499f876c96af9c9e4629feab9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22080/mbox/","series":[{"id":4819,"url":"https://patchwork.libcamera.org/api/1.1/series/4819/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4819","date":"2024-11-25T15:29:59","name":"Add direction field to ControlId","version":1,"mbox":"https://patchwork.libcamera.org/series/4819/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22080/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22080/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E93BC32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 15:30:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F01A666040;\n\tMon, 25 Nov 2024 16:30:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36DCD6603D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 16:30:20 +0100 (CET)","from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:9d06:dcbb:7303:4be6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A0B4912E9;\n\tMon, 25 Nov 2024 16:29:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"meH5007X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732548598;\n\tbh=Mv19DzoGdexe9gDai8YxU1/+ZgP8sxyLMS2T2pqJB2U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=meH5007XPkv0UM6RZGhUfGSfRc/RmHyKhzeHNBVSi9ATKOiMsj8gFsVFrkNHRozYq\n\t4il4s8hdBQ7l7j6z42MHvGlvTZ2ew3dVX5iaoJ+jIO9W1yHQlf5/gUPhGy+gsgXVpq\n\tWn/qrrf5GYCyUjWe4icVJGliOOL1qyZRASMyjrew=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder <paul.elder@ideasonboard.com>","Subject":"[PATCH 4/4] apps: cam: Print control direction information","Date":"Tue, 26 Nov 2024 00:30:03 +0900","Message-Id":"<20241125153003.3309066-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20241125153003.3309066-1-paul.elder@ideasonboard.com>","References":"<20241125153003.3309066-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Now that there is support for retrieving the allowed directions of a\ncontrol, print this information when listing controls.\n\nSample output:\n$ cam --list-controls -c 2\nUsing camera Virtual0 as cam0\nControl: [io] draft::FaceDetectMode:\n  - FaceDetectModeOff (0)\nControl: [i ] libcamera::FrameDurationLimits: [16666..33333]\n   Size: 2\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 6e9890ccfda1..1baf36fcfd3c 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -159,12 +159,18 @@ CameraSession::~CameraSession()\n void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n+\t\tstd::stringstream io;\n+\t\tio << \"[\"\n+\t\t   << (id->isInput() ? \"i\" : \" \")\n+\t\t   << (id->isOutput() ? \"o\" : \" \")\n+\t\t   << \"] \";\n+\n \t\tif (info.values().empty()) {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t  << id->vendor() << \"::\" << id->name() << \": \"\n \t\t\t\t  << info.toString() << std::endl;\n \t\t} else {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t  << id->vendor() << \"::\" << id->name() << \":\"\n \t\t\t\t  << std::endl;\n \t\t\tfor (const auto &value : info.values()) {\n","prefixes":["4/4"]}