{"id":22068,"url":"https://patchwork.libcamera.org/api/1.1/patches/22068/?format=json","web_url":"https://patchwork.libcamera.org/patch/22068/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241125151430.2437285-2-stefan.klug@ideasonboard.com>","date":"2024-11-25T15:14:10","name":"[v2,1/8] libcamera: rkisp1: Fix scope of dewarper stop() exit action","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"61e258ccfc4ca6185a3766861e8895540cc63f3e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22068/mbox/","series":[{"id":4818,"url":"https://patchwork.libcamera.org/api/1.1/series/4818/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4818","date":"2024-11-25T15:14:09","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":2,"mbox":"https://patchwork.libcamera.org/series/4818/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22068/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22068/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54203C32A3\n\tfor ;\n\tMon, 25 Nov 2024 15:14:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 039DF65F76;\n\tMon, 25 Nov 2024 16:14:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F07B365F5A\n\tfor ;\n\tMon, 25 Nov 2024 16:14:37 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4cf:a935:de6f:a329])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 284296B5;\n\tMon, 25 Nov 2024 16:14:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DNP4YCFv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732547656;\n\tbh=0Aa7FvXUGXvpviXw862Z2hJ2rHPTDooK68rBTSbgP5c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DNP4YCFvLUP9+vBf28RCjH32n5emhktqKz9YWf3Pxy0CpsUqAzXsJd0lqXrdCrZy7\n\towrol7/7B2te+A+ACM0ZQscm/QpcJ/rXZ5CvCIsP5iI5hJC7BBSeYIMXxcIl9B7g8W\n\t4OvqqVYN8isaM4QnLwJIpAvOzTbHYtZD+YrO7feo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ,\n\tJacopo Mondi ","Subject":"[PATCH v2 1/8] libcamera: rkisp1: Fix scope of dewarper stop() exit\n\taction","Date":"Mon, 25 Nov 2024 16:14:10 +0100","Message-ID":"<20241125151430.2437285-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241125151430.2437285-1-stefan.klug@ideasonboard.com>","References":"<20241125151430.2437285-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the definition of the dewarper stop() action into the scope were\nthe corresponding start() happens.\n\nFixes: 12b553d691d4 (\"libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\")\nSigned-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \nReviewed-by: Jacopo Mondi \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 6c6d711f91b3..5ffcfbce56be 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1043,8 +1043,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL\n \t\t\t\tLOG(RkISP1, Error) << \"Failed to start dewarper\";\n \t\t\t\treturn ret;\n \t\t\t}\n+\t\t\tactions += [&]() { dewarper_->stop(); };\n \t\t}\n-\t\tactions += [&]() { dewarper_->stop(); };\n \t}\n \n \tif (data->mainPath_->isEnabled()) {\n","prefixes":["v2","1/8"]}