{"id":22054,"url":"https://patchwork.libcamera.org/api/1.1/patches/22054/?format=json","web_url":"https://patchwork.libcamera.org/patch/22054/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241121085800.3208123-2-chenghaoyang@chromium.org>","date":"2024-11-21T08:57:16","name":"[v5,1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4345cb807d2f6008fde1b6d0d4f893af7bea723b","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22054/mbox/","series":[{"id":4812,"url":"https://patchwork.libcamera.org/api/1.1/series/4812/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4812","date":"2024-11-21T08:57:16","name":"[v5,1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties","version":5,"mbox":"https://patchwork.libcamera.org/series/4812/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22054/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22054/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93734C32FB\n\tfor ;\n\tThu, 21 Nov 2024 08:58:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E96165FB0;\n\tThu, 21 Nov 2024 09:58:12 +0100 (CET)","from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n\t[IPv6:2607:f8b0:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD6965FB3\n\tfor ;\n\tThu, 21 Nov 2024 09:58:09 +0100 (CET)","by mail-pl1-x636.google.com with SMTP id\n\td9443c01a7336-2124a86f4cbso5562265ad.3\n\tfor ;\n\tThu, 21 Nov 2024 00:58:09 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-212882d1c66sm8734775ad.138.2024.11.21.00.58.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 21 Nov 2024 00:58:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"OwJeyJbn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732179487; x=1732784287;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=N6DWD2m3kMuwEUR6nP5EWLaEJ601hgOnv73zR3F3bKM=;\n\tb=OwJeyJbnQyvPdMAZ7xHjXbnZgtdskZXDPrkKglTs3ESxAw83pe1rVgj/9Elb/Gy0Ab\n\tnETETsMURZm6taCGDIkNJr2poMSXfsLG5pHSJmCw5nHNLT4sv+Z/weenpXq89Dilg3wE\n\txKuAUtMsBus9gvs83FsfkDRPPFBYnobWrVdik=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732179487; x=1732784287;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=N6DWD2m3kMuwEUR6nP5EWLaEJ601hgOnv73zR3F3bKM=;\n\tb=LOVRQnTyK5UYky0uVySUcJ5tsnu0u5NihJMNbgHi1QNP5+caIDyesHGMGayWC916uQ\n\tlRnEjkDO8Y9fYdKExpW/Z0texAg+6svhHtH57R8NUg1A2Dy0NQMfFyR01TbbZG0WSF3j\n\tph7xjT9a8apZjU/gn5r/aC1eGphOPCrK2YwOguzHXimLdEs16VKKvkmlt6f+QeFEa9z8\n\toLnBaaW5CLxxiticuwhhUKGAsVAyWAOlSLqUHpWYfSdP2ANre/ic38py40+wC/5wt6ig\n\t2Gvk1wa3mueQwJ5/tP8pDEgqZ5+SYaUumPT7zjS7v/JUES7Jai6ckYzjsNpeuNg04K9V\n\tS/Pw==","X-Gm-Message-State":"AOJu0YyzDD2kOxxJhm600s1kxcU+Z6DrZfN6L7jou0C4WkdXbnXQsS74\n\tqPLpJt5mOl2cWQxlgawgrkaJ5yPsW4s3MgjHNafuJHhVqHCgxBfyTrLefDXq2meTKBOo/Xy5dxQ\n\t=","X-Gm-Gg":"ASbGncu1DvPJf+2WTJgHqlu095qRiR8VOvaQzX8bJuilVJrEkQMhBIQRsuQ+LhqjbLE\n\tpYltyT+3zRFdb0995GTlp66vsmcTsjD5/VDxDCbJOfE96agoAB1otusdPAb/aOmVPdpP02PPLu0\n\tKc7bS+t0LrisBW0JnFORXZxQs9dV9A6whrwNgLXVOC7QuW2MlTdry6B/MVwjUmsLhmRNEunvCBv\n\txiTJEEZ69kDXY1k23sSDcL9mLaPY+Vi4naWipixtQ8lvKec1mzEDYd9t/n6lbTQN9IJjWZo8W5a\n\tM1GAPJVDQCUAetTID1oywWUy5v36W9tpX3WthWp6aRJAJ8FvDsLWlw==","X-Google-Smtp-Source":"AGHT+IHFvBXW6MYLvAABqmxeqx25QssJcWpN1fVGb2yM9tKRBfXJobD4FwJdn4dfoTnBPGf09ItxCQ==","X-Received":"by 2002:a17:902:d551:b0:211:a6d:85e8 with SMTP id\n\td9443c01a7336-2126a42ed32mr65333065ad.39.1732179487329; \n\tThu, 21 Nov 2024 00:58:07 -0800 (PST)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ,\n\tHarvey Yang ","Subject":"[PATCH v5 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","Date":"Thu, 21 Nov 2024 08:57:16 +0000","Message-ID":"<20241121085800.3208123-2-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.338.g60cca15819-goog","In-Reply-To":"<20241121085800.3208123-1-chenghaoyang@chromium.org>","References":"<20241121085800.3208123-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Harvey Yang \n\nProvide the GalaxyCore gc05a2 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen \nCo-developed-by: Xing Gu \nCo-developed-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 7 +++++++\n 2 files changed, 20 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex c6169bdc7..3067d9bc1 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -519,6 +519,19 @@ private:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n \n+class CameraSensorHelperGc05a2 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc05a2()\n+\t{\n+\t\t/* From datasheet: 64 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6d4136d03..2f048d4a3 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -70,6 +70,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBarsFadeToGray, 3 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc05a2\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n","prefixes":["v5","1/2"]}