{"id":22006,"url":"https://patchwork.libcamera.org/api/1.1/patches/22006/?format=json","web_url":"https://patchwork.libcamera.org/patch/22006/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241119121928.30939-9-laurent.pinchart@ideasonboard.com>","date":"2024-11-19T12:19:19","name":"[v4,08/17] ipa: libipa: vector: Add compound assignment operators","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"eac4281a50cafe6c4ad53c59d0b8aaa29ba710c7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22006/mbox/","series":[{"id":4804,"url":"https://patchwork.libcamera.org/api/1.1/series/4804/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4804","date":"2024-11-19T12:19:11","name":"Improve linear algebra helpers in libipa","version":4,"mbox":"https://patchwork.libcamera.org/series/4804/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22006/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22006/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A13DC32F3\n\tfor ;\n\tTue, 19 Nov 2024 12:20:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05D3D65F2B;\n\tTue, 19 Nov 2024 13:20:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E1A865F20\n\tfor ;\n\tTue, 19 Nov 2024 13:20:03 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 107351624\n\tfor ;\n\tTue, 19 Nov 2024 13:19:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IIWleVmf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018786;\n\tbh=hICb8bQOp8g75pM+UxOA+VpNvJncTdtc3A+j1qtsNBo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=IIWleVmfk4RzrxZOBz3eJhmjjMkoJhhPRYu09lvBq0IkYp14UO8GQJMgXSzlwkHjH\n\tp1UKuUkHTmM6BinWEIH6MMCSC2zneCX8vYEkpL0+V2JRiJ0HbtcXCN11t1Rv5eYFrK\n\tTTvEjw2UbeJXWOZlGzyfVaoDCfX5glVoBR7HcW4E=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v4 08/17] ipa: libipa: vector: Add compound assignment\n\toperators","Date":"Tue, 19 Nov 2024 14:19:19 +0200","Message-ID":"<20241119121928.30939-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","References":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Extend the Vector class with compound assignment operators that match\nthe binary arithmetic operators.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Milan Zamazal \n---\nChanges since v3:\n\n- Replace std::function with a templated argument\n\nChanges since v2:\n\n- Use std::plus, std::minus, std::multiplies and std::divides\n---\n src/ipa/libipa/vector.cpp | 56 +++++++++++++++++++++++++++++++++++++\n src/ipa/libipa/vector.h | 59 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 115 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 13aaacbed20e..3305dcb38e6b 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -133,6 +133,62 @@ namespace ipa {\n * \\return The element-wise division of this vector by \\a scalar\n */\n \n+/**\n+ * \\fn Vector::operator+=(Vector const &other)\n+ * \\brief Add \\a other element-wise to this vector\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator+=(T scalar)\n+ * \\brief Add \\a scalar element-wise to this vector\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator-=(Vector const &other)\n+ * \\brief Subtract \\a other element-wise from this vector\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator-=(T scalar)\n+ * \\brief Subtract \\a scalar element-wise from this vector\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*=(const Vector &other)\n+ * \\brief Multiply this vector by \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*=(T scalar)\n+ * \\brief Multiply this vector by \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator/=(const Vector &other)\n+ * \\brief Divide this vector by \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return This vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator/=(T scalar)\n+ * \\brief Divide this vector by \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return This vector\n+ */\n+\n /**\n * \\fn Vector::dot(const Vector &other) const\n * \\brief Compute the dot product\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 6e24cdcebec0..683bf9ee2564 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -112,6 +112,46 @@ public:\n \t\treturn apply(*this, scalar, std::divides<>{});\n \t}\n \n+\tVector &operator+=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a + b; });\n+\t}\n+\n+\tVector &operator+=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a + b; });\n+\t}\n+\n+\tVector &operator-=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tVector &operator-=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a - b; });\n+\t}\n+\n+\tVector &operator*=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tVector &operator*=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a * b; });\n+\t}\n+\n+\tVector &operator/=(const Vector &other)\n+\t{\n+\t\treturn apply(other, [](T a, T b) { return a / b; });\n+\t}\n+\n+\tVector &operator/=(T scalar)\n+\t{\n+\t\treturn apply(scalar, [](T a, T b) { return a / b; });\n+\t}\n+\n \tconstexpr T dot(const Vector &other) const\n \t{\n \t\tT ret = 0;\n@@ -206,6 +246,25 @@ private:\n \t\treturn result;\n \t}\n \n+\ttemplate\n+\tVector &apply(const Vector &other, BinaryOp op)\n+\t{\n+\t\tauto itOther = other.data_.begin();\n+\t\tstd::for_each(data_.begin(), data_.end(),\n+\t\t\t [&op, &itOther](T &v) { v = op(v, *itOther++); });\n+\n+\t\treturn *this;\n+\t}\n+\n+\ttemplate\n+\tVector &apply(T scalar, BinaryOp op)\n+\t{\n+\t\tstd::for_each(data_.begin(), data_.end(),\n+\t\t\t [&op, scalar](T &v) { v = op(v, scalar); });\n+\n+\t\treturn *this;\n+\t}\n+\n \tstd::array data_;\n };\n \n","prefixes":["v4","08/17"]}