{"id":22003,"url":"https://patchwork.libcamera.org/api/1.1/patches/22003/?format=json","web_url":"https://patchwork.libcamera.org/patch/22003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241119121928.30939-6-laurent.pinchart@ideasonboard.com>","date":"2024-11-19T12:19:16","name":"[v4,05/17] ipa: libipa: vector: Rename the dot product operator*() to dot()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"589d1cd5d9346feeff3fe0c56610553d274263e0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22003/mbox/","series":[{"id":4804,"url":"https://patchwork.libcamera.org/api/1.1/series/4804/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4804","date":"2024-11-19T12:19:11","name":"Improve linear algebra helpers in libipa","version":4,"mbox":"https://patchwork.libcamera.org/series/4804/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE625C32F5\n\tfor ;\n\tTue, 19 Nov 2024 12:19:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 262AA65F22;\n\tTue, 19 Nov 2024 13:19:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F399065F14\n\tfor ;\n\tTue, 19 Nov 2024 13:19:54 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88C8ED49\n\tfor ;\n\tTue, 19 Nov 2024 13:19:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JQfgUxao\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018777;\n\tbh=8dQk9SQr1x/Gh45wEdyiVeTYZY16d5Ir9LJxw4yIUYY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=JQfgUxaoO7AuYHWPiLoa3XipmHjTT5IHvxSvVx91WiMSaRbsQAu7MRX2tFEzwt96v\n\tSH6idUylFLaj1w/Cqw5TQbxkX6Aqj0eN6thogS8VAF7VaxKujGH3mh2/315NDJ9jpL\n\tetdwj2RB0t8Zf/02g6Zaow5t1UhWj1UsWxg71zws=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v4 05/17] ipa: libipa: vector: Rename the dot product\n\toperator*() to dot()","Date":"Tue, 19 Nov 2024 14:19:16 +0200","Message-ID":"<20241119121928.30939-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","References":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Vector class defines a set of arithmetic operators between two\nvectors or a vector and a scalar. All the operators perform element-wise\noperations, except for the operator*() that computes the dot product.\nThis is inconsistent and confusing. Replace the operator with a dot()\nfunction.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Milan Zamazal \n---\n src/ipa/libipa/vector.cpp | 14 +++++++-------\n src/ipa/libipa/vector.h | 16 ++++++++--------\n 2 files changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex a9779fa2b8e2..473e6d8bad01 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -91,13 +91,6 @@ namespace ipa {\n * \\return The sum of the two vectors\n */\n \n-/**\n- * \\fn Vector::operator*(const Vector &other) const\n- * \\brief Compute the dot product\n- * \\param[in] other The other vector\n- * \\return The dot product of the two vectors\n- */\n-\n /**\n * \\fn Vector::operator*(T factor) const\n * \\brief Multiply the vector by a scalar\n@@ -112,6 +105,13 @@ namespace ipa {\n * \\return The vector divided by \\a factor\n */\n \n+/**\n+ * \\fn Vector::dot(const Vector &other) const\n+ * \\brief Compute the dot product\n+ * \\param[in] other The other vector\n+ * \\return The dot product of the two vectors\n+ */\n+\n /**\n * \\fn constexpr T &Vector::x()\n * \\brief Convenience function to access the first element of the vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 1022550e6170..b4eb19707063 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -86,14 +86,6 @@ public:\n \t\treturn ret;\n \t}\n \n-\tconstexpr T operator*(const Vector &other) const\n-\t{\n-\t\tT ret = 0;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret += data_[i] * other[i];\n-\t\treturn ret;\n-\t}\n-\n \tconstexpr Vector operator*(T factor) const\n \t{\n \t\tVector ret;\n@@ -110,6 +102,14 @@ public:\n \t\treturn ret;\n \t}\n \n+\tconstexpr T dot(const Vector &other) const\n+\t{\n+\t\tT ret = 0;\n+\t\tfor (unsigned int i = 0; i < Rows; i++)\n+\t\t\tret += data_[i] * other[i];\n+\t\treturn ret;\n+\t}\n+\n #ifndef __DOXYGEN__\n \ttemplate= 1>>\n #endif /* __DOXYGEN__ */\n","prefixes":["v4","05/17"]}