{"id":21987,"url":"https://patchwork.libcamera.org/api/1.1/patches/21987/?format=json","web_url":"https://patchwork.libcamera.org/patch/21987/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241119101452.20808-1-naush@raspberrypi.com>","date":"2024-11-19T10:14:52","name":"[v2] ipa: rpi: awb: Disable CT search bias for Grey World AWB","commit_ref":"934bbfce24f961c04132b8bb8bd66ea1ae999394","pull_url":null,"state":"accepted","archived":false,"hash":"5ca9f3b9569915ac6e994f9cece1dd005e1d8d32","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21987/mbox/","series":[{"id":4802,"url":"https://patchwork.libcamera.org/api/1.1/series/4802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4802","date":"2024-11-19T10:14:52","name":"[v2] ipa: rpi: awb: Disable CT search bias for Grey World AWB","version":2,"mbox":"https://patchwork.libcamera.org/series/4802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21987/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21987/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C22F2C32F1\n\tfor ;\n\tTue, 19 Nov 2024 10:14:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0019665EEB;\n\tTue, 19 Nov 2024 11:14:57 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 706C76589D\n\tfor ;\n\tTue, 19 Nov 2024 11:14:56 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-4315549c4d5so5707395e9.0\n\tfor ;\n\tTue, 19 Nov 2024 02:14:56 -0800 (PST)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-432dab807d4sm187203175e9.21.2024.11.19.02.14.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 Nov 2024 02:14:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"R7ZoJjqh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1732011295; x=1732616095;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=R9jR0meTlaGVa3TOuurcXiqninCYpYOfJ1oIsW+ZkuM=;\n\tb=R7ZoJjqhl5ZNAeqjtFTOr/96ecQUZVZ6o6PNa1+VEqZikJQBY+xgStyR6QHlm1nldI\n\tEwaLCJ1KkWSO8pI+d6giQaw621Cf+SRo3voX+EGKfg6WKDcOIoOm1PHKAMuJRErfVYjN\n\tOqDtoQwUl6KDvcLttnwIVW6W7cYkkZfwG2s1muitUlVAbswLT0Q0GwW3hLRzBQ8nilg5\n\tU3sQv/2evU04BxH2icV3jiaM5Mv0+h/HRCBKBjlBGKnWxTEZ8gz7MviQCqefWsjoQO8R\n\tQZqlLbjac0iHCeFg7G+D6rq7chPXBDqDx3fTjlHErLmom7G/pu9scqsPXUB0Wzwwv2Su\n\trPQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732011295; x=1732616095;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=R9jR0meTlaGVa3TOuurcXiqninCYpYOfJ1oIsW+ZkuM=;\n\tb=KU5ePFQyH/sQXlUA9t+KJk5PmYgCIs9JzCeGKMWzPXxd1f75Ce96R69p5Hv6iRhh/A\n\td4xImS7vkruTYHkufP7u9G9RquWKUTPKEsGv1ZwXUHGzxUT0Wlm4Lln7hnFS13RK9Ge4\n\tag/ZhhippPme7taUpVEJO6W7KN2uD3x2iP/GGhGr4NVfKQvb/ScZ6GmFVaK4ONBCn5WW\n\tV9GT6zOdTwUCTHyYx9Efte+l+stjkRe2luQ+tQNmdKusFxMzncG/iJIUpBuVHh4sEsBR\n\tKoR4G0a1eLi/wFn3xnFg1LbLZwZNmlLGwgobynz8is1mY40TuhTSwCpHfZjs10KNLGS4\n\tNzfA==","X-Gm-Message-State":"AOJu0YzeslfLFaQHnRzqTRtVQQYyciHLs88WWZ+QSoY063FLKf58E0wh\n\tNiSSb4yzpsJR+PP3//RQm3vJGWzuc+Lk3VkUUAIdXJrqEbKVorTnEd1ZwoEFzRI2QFDilch0M8x\n\td","X-Google-Smtp-Source":"AGHT+IGANfmLys+xMpGsrXtysZeg3k1xMhoBzFgd7srPpOv79hHwM3Sy7Pj3BKDEkTA2lsVHUn94xg==","X-Received":"by 2002:a05:600c:1c1f:b0:431:4a7e:a121 with SMTP id\n\t5b1f17b1804b1-432df79d180mr56809465e9.9.1732011295497; \n\tTue, 19 Nov 2024 02:14:55 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDavid Plowman ,\n\tKieran Bingham ","Subject":"[PATCH v2] ipa: rpi: awb: Disable CT search bias for Grey World AWB","Date":"Tue, 19 Nov 2024 10:14:52 +0000","Message-Id":"<20241119101452.20808-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If grey world AWB is setup in the tuning file, the CT curve will either\nbe missing or invalid. Disable biasing the statistics for the search in\nsuch cases.\n\nFixes: ea8fd63d936f (\"ipa: rpi: awb: Add a bias to the AWB search\")\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Kieran Bingham \n---\n src/ipa/rpi/controller/rpi/awb.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\nindex 9d8e170d1bfe..c277a1764112 100644\n--- a/src/ipa/rpi/controller/rpi/awb.cpp\n+++ b/src/ipa/rpi/controller/rpi/awb.cpp\n@@ -459,10 +459,11 @@ void Awb::prepareStats()\n \t * LSC has already been applied to the stats in this pipeline, so stop\n \t * any LSC compensation. We also ignore config_.fast in this version.\n \t */\n+\tconst double biasCtR = config_.bayes ? config_.ctR.eval(config_.biasCT) : 0;\n+\tconst double biasCtB = config_.bayes ? config_.ctB.eval(config_.biasCT) : 0;\n \tgenerateStats(zones_, statistics_, config_.minPixels,\n \t\t config_.minG, getGlobalMetadata(),\n-\t\t config_.biasProportion, config_.ctR.eval(config_.biasCT),\n-\t\t config_.ctB.eval(config_.biasCT));\n+\t\t config_.biasProportion, biasCtR, biasCtB);\n \t/*\n \t * apply sensitivities, so values appear to come from our \"canonical\"\n \t * sensor.\n","prefixes":["v2"]}