{"id":21964,"url":"https://patchwork.libcamera.org/api/1.1/patches/21964/?format=json","web_url":"https://patchwork.libcamera.org/patch/21964/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118221618.13953-5-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T22:16:05","name":"[v3,04/17] ipa: libipa: vector: Add copy constructor and assignment operator","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e75d2b95566d517901c622d5176dc3ac1c34b153","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21964/mbox/","series":[{"id":4798,"url":"https://patchwork.libcamera.org/api/1.1/series/4798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4798","date":"2024-11-18T22:16:01","name":"Improve linear algebra helpers in libipa","version":3,"mbox":"https://patchwork.libcamera.org/series/4798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21964/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21964/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F858C32EA\n\tfor ;\n\tMon, 18 Nov 2024 22:16:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD9F1658FB;\n\tMon, 18 Nov 2024 23:16:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7E1B658F9\n\tfor ;\n\tMon, 18 Nov 2024 23:16:33 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B48778DB\n\tfor ;\n\tMon, 18 Nov 2024 23:16:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wZVblFTt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968176;\n\tbh=8rcuaTIQJIPsp30V5RFodG0Vgjh3hhCgRHL2U2sQoro=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=wZVblFTtAXixJ5xQJwHbhIE+pAnV+RuSETtCD4/mdzBOGwKLggZAhzj/iE6453gAa\n\tVaFDKafpVmqIKvO8oMxjthEFuE6pcAHj5HQnm/ADnbOrAqQJR2Tv6BD2X9fi2sWvGy\n\tSg+ag5Qoe/VQ/qslhiX3G0z+Kvyh2Dct6l3zbVfI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 04/17] ipa: libipa: vector: Add copy constructor and\n\tassignment operator","Date":"Tue, 19 Nov 2024 00:16:05 +0200","Message-ID":"<20241118221618.13953-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","References":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is useful to assign a value to an existing vector. Define a copy\nconstructor and a copy assignment operator.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Milan Zamazal \n---\nChanges since v2:\n\n- Make copy constructor constexpr\n- Drop #include \n---\n src/ipa/libipa/vector.cpp | 13 +++++++++++++\n src/ipa/libipa/vector.h | 12 ++++++++++++\n 2 files changed, 25 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex d414ba97e41e..80f1758578f0 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -46,6 +46,19 @@ namespace ipa {\n * The size of \\a data must be equal to the dimension size Rows of the vector.\n */\n \n+/**\n+ * \\fn Vector::Vector(const Vector &other)\n+ * \\brief Construct a Vector by copying \\a other\n+ * \\param[in] other The other Vector value\n+ */\n+\n+/**\n+ * \\fn Vector &Vector::operator=(const Vector &other)\n+ * \\brief Replace the content of the Vector with a copy of the content of \\a other\n+ * \\param[in] other The other Vector value\n+ * \\return This Vector value\n+ */\n+\n /**\n * \\fn T Vector::operator[](size_t i) const\n * \\brief Index to an element in the vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex be568eadfeac..35fc9539dc99 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -46,6 +46,18 @@ public:\n \t\t\tdata_[i] = data[i];\n \t}\n \n+\tconstexpr Vector(const Vector &other)\n+\t\t: data_(other.data_)\n+\t{\n+\t}\n+\n+\tVector &operator=(const Vector &other)\n+\t{\n+\t\tdata_ = other.data_;\n+\n+\t\treturn *this;\n+\t}\n+\n \tconst T &operator[](size_t i) const\n \t{\n \t\tASSERT(i < data_.size());\n","prefixes":["v3","04/17"]}