{"id":21963,"url":"https://patchwork.libcamera.org/api/1.1/patches/21963/?format=json","web_url":"https://patchwork.libcamera.org/patch/21963/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118221618.13953-4-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T22:16:04","name":"[v3,03/17] ipa: libipa: vector: Add scalar constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f97c6067bafb68b43d8c790802a7a20099720ee6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21963/mbox/","series":[{"id":4798,"url":"https://patchwork.libcamera.org/api/1.1/series/4798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4798","date":"2024-11-18T22:16:01","name":"Improve linear algebra helpers in libipa","version":3,"mbox":"https://patchwork.libcamera.org/series/4798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21963/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21963/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BC70C32EA\n\tfor ;\n\tMon, 18 Nov 2024 22:16:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 377AD658FE;\n\tMon, 18 Nov 2024 23:16:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 623F8658EF\n\tfor ;\n\tMon, 18 Nov 2024 23:16:32 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DB2D8DB\n\tfor ;\n\tMon, 18 Nov 2024 23:16:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dWg+j6vf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968175;\n\tbh=/F4cJONraqeugqVic2iAeCnfpBopoCBdtsQ4oAySm3U=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=dWg+j6vf0oBTfnTkzlCn2ubnNbYcwE9tZCIJbzQ+YwlLwIHseg2U/mjG64Sakkl+2\n\t1s6SMGlJ28pUF5A15PAgoIq7gROWX1r3w2aHXgxh/4Wf0hM0uqP6cvoj088HhA+1Hx\n\tjTSkMqyvhpGkMxuOelmcXaf/Etxr/ioUPm4tkljM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 03/17] ipa: libipa: vector: Add scalar constructor","Date":"Tue, 19 Nov 2024 00:16:04 +0200","Message-ID":"<20241118221618.13953-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","References":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The default constructor leaves the vector data uninitialized. Add a\nconstructor to fill the vector with copies of a scalar value, and fix\nthe documentation of the default constructor.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.cpp | 8 +++++++-\n src/ipa/libipa/vector.h | 5 +++++\n 2 files changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex f14f155216f3..d414ba97e41e 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -29,7 +29,13 @@ namespace ipa {\n \n /**\n * \\fn Vector::Vector()\n- * \\brief Construct a zero vector\n+ * \\brief Construct an uninitialized vector\n+ */\n+\n+/**\n+ * \\fn Vector::Vector(T scalar)\n+ * \\brief Construct a vector filled with a \\a scalar value\n+ * \\param[in] scalar The scalar value\n */\n \n /**\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex b72ab9851aa3..be568eadfeac 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -35,6 +35,11 @@ class Vector\n public:\n \tconstexpr Vector() = default;\n \n+\tconstexpr Vector(T scalar)\n+\t{\n+\t\tdata_.fill(scalar);\n+\t}\n+\n \tconstexpr Vector(const std::array &data)\n \t{\n \t\tfor (unsigned int i = 0; i < Rows; i++)\n","prefixes":["v3","03/17"]}