{"id":21947,"url":"https://patchwork.libcamera.org/api/1.1/patches/21947/?format=json","web_url":"https://patchwork.libcamera.org/patch/21947/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118000738.18977-6-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T00:07:31","name":"[RFC,v2,05/12] ipa: libipa: vector: Generalize arithmetic operators","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4cbad9b241a66f68bf35ec9af3a312c036d8c555","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21947/mbox/","series":[{"id":4796,"url":"https://patchwork.libcamera.org/api/1.1/series/4796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4796","date":"2024-11-18T00:07:26","name":"Improve linear algebra helpers in libipa","version":2,"mbox":"https://patchwork.libcamera.org/series/4796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21947/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21947/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4453C330B\n\tfor ;\n\tMon, 18 Nov 2024 00:08:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4B02658B9;\n\tMon, 18 Nov 2024 01:07:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70BE8658BB\n\tfor ;\n\tMon, 18 Nov 2024 01:07:54 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A30075A\n\tfor ;\n\tMon, 18 Nov 2024 01:07:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vmHVbqXx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731888458;\n\tbh=gU/DViUqdbRwz7vQMTvWxLxbGsGYNHcOZNJfvv/FUr0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vmHVbqXxMMkg2Yt9frForW9Sp8gKI+2ZynZqoacCQ0t1Fc1N99rnVGE8OAoq0/NZS\n\tHID5U9jFRP9qY8mkWDE02wie5ueqrxNgDEDB2qIfjX2EqwYRkiythaxR7Jdvu8HlUy\n\t+BjqaMIjdtgMLNobLGkgipgWvKn8nkCnO32cFjD4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 05/12] ipa: libipa: vector: Generalize arithmetic\n\toperators","Date":"Mon, 18 Nov 2024 02:07:31 +0200","Message-ID":"<20241118000738.18977-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of hand-coding all arithmetic operators, implement them based on\na generic apply() function that takes an operator-specific\nstd::function. This will simplify adding missing arithmetic operators.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.h | 48 ++++++++++++++++++++++++-----------------\n 1 file changed, 28 insertions(+), 20 deletions(-)","diff":"diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 9dabdc28a540..8c4edfbaf85f 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -74,36 +74,24 @@ public:\n \t\treturn ret;\n \t}\n \n-\tconstexpr Vector operator-(const Vector &other) const\n+\tconstexpr Vector operator-(const Vector &other) const\n \t{\n-\t\tVector ret;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret[i] = data_[i] - other[i];\n-\t\treturn ret;\n+\t\treturn apply(*this, other, [](T a, T b) { return a - b; });\n \t}\n \n-\tconstexpr Vector operator+(const Vector &other) const\n+\tconstexpr Vector operator+(const Vector &other) const\n \t{\n-\t\tVector ret;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret[i] = data_[i] + other[i];\n-\t\treturn ret;\n+\t\treturn apply(*this, other, [](T a, T b) { return a + b; });\n \t}\n \n-\tconstexpr Vector operator*(T factor) const\n+\tconstexpr Vector operator*(T factor) const\n \t{\n-\t\tVector ret;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret[i] = data_[i] * factor;\n-\t\treturn ret;\n+\t\treturn apply(*this, factor, [](T a, T b) { return a * b; });\n \t}\n \n-\tconstexpr Vector operator/(T factor) const\n+\tconstexpr Vector operator/(T factor) const\n \t{\n-\t\tVector ret;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret[i] = data_[i] / factor;\n-\t\treturn ret;\n+\t\treturn apply(*this, factor, [](T a, T b) { return a / b; });\n \t}\n \n \tconstexpr T dot(const Vector &other) const\n@@ -178,6 +166,26 @@ public:\n \t}\n \n private:\n+\tstatic constexpr Vector apply(const Vector &lhs, const Vector &rhs, std::function func)\n+\t{\n+\t\tVector result;\n+\t\tstd::transform(lhs.data_.begin(), lhs.data_.end(),\n+\t\t\t rhs.data_.begin(), result.data_.begin(),\n+\t\t\t func);\n+\n+\t\treturn result;\n+\t}\n+\n+\tstatic constexpr Vector apply(const Vector &lhs, T rhs, std::function func)\n+\t{\n+\t\tVector result;\n+\t\tstd::transform(lhs.data_.begin(), lhs.data_.end(),\n+\t\t\t result.data_.begin(),\n+\t\t\t [&func, rhs](T v) { return func(v, rhs); });\n+\n+\t\treturn result;\n+\t}\n+\n \tstd::array data_;\n };\n \n","prefixes":["RFC","v2","05/12"]}