{"id":21910,"url":"https://patchwork.libcamera.org/api/1.1/patches/21910/?format=json","web_url":"https://patchwork.libcamera.org/patch/21910/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241115101334.453104-7-dan.scally@ideasonboard.com>","date":"2024-11-15T10:13:26","name":"[v6,06/14] libcamera: mali-c55: Add stride and size to rawConfig","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cf43e8a19d82d68a5505a8d189dd94e114579283","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21910/mbox/","series":[{"id":4793,"url":"https://patchwork.libcamera.org/api/1.1/series/4793/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4793","date":"2024-11-15T10:13:20","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":6,"mbox":"https://patchwork.libcamera.org/series/4793/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21910/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21910/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79723C3261\n\tfor ;\n\tFri, 15 Nov 2024 10:14:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF10A65888;\n\tFri, 15 Nov 2024 11:14:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4196600F2\n\tfor ;\n\tFri, 15 Nov 2024 11:13:49 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 181C71340;\n\tFri, 15 Nov 2024 11:13:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HfbLU0nr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731665615;\n\tbh=B9Q3EyGYlyZ0IRqms02XCEZhyCH1rICvMkeSp7dJQvQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HfbLU0nr/daNIDOLwyYNwtTYLZfBrXyyytgnhESwFmMsbVBb26/7MveDTwVt33UiP\n\tVNdcDhN3QqR45PawWmIU+UHLS01a82gdBQICvbhtaz52FUEqgDlG0NIQE4mvnGw/hL\n\toBax9o3Qk96qXFTQOR3nrOXRv2nuJ+er106Msb/4=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Anthony.McGivern@arm.com, Daniel Scally ,\n\tJacopo Mondi ,\n\tKieran Bingham ,\n\tUmang Jain ","Subject":"[PATCH v6 06/14] libcamera: mali-c55: Add stride and size to\n\trawConfig","Date":"Fri, 15 Nov 2024 10:13:26 +0000","Message-Id":"<20241115101334.453104-7-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241115101334.453104-1-dan.scally@ideasonboard.com>","References":"<20241115101334.453104-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Complete the RAW StreamConfiguration by populating the frame stride and\nthe frame size.\n\nSet the minimum required alignment to 4 bytes as the Mali C55 ISP output\nexpands RAW output to 16 bits and a RAW Bayer macro-pixel requires\ntwo samples to be complete.\n\nSigned-off-by: Daniel Scally \nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \nReviewed-by: Umang Jain \n---\nChanges in v6:\n\n\t- None\n\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 330006db..a35aa92a 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -366,6 +366,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \n \t\tmaxSize = rawSize;\n \n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n+\t\trawConfig->stride = info.stride(rawConfig->size.width, 0, 4);\n+\t\trawConfig->frameSize = info.frameSize(rawConfig->size, 4);\n+\n \t\trawConfig->setStream(const_cast(&data_->frStream_));\n \t\tfrPipeAvailable = false;\n \t}\n","prefixes":["v6","06/14"]}