{"id":21907,"url":"https://patchwork.libcamera.org/api/1.1/patches/21907/?format=json","web_url":"https://patchwork.libcamera.org/patch/21907/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241115101334.453104-4-dan.scally@ideasonboard.com>","date":"2024-11-15T10:13:23","name":"[v6,03/14] libcamera: mali-c55: Init camera properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1aca73ed991770979887e9913c105c729c720980","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21907/mbox/","series":[{"id":4793,"url":"https://patchwork.libcamera.org/api/1.1/series/4793/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4793","date":"2024-11-15T10:13:20","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":6,"mbox":"https://patchwork.libcamera.org/series/4793/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21907/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21907/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48A79C3261\n\tfor ;\n\tFri, 15 Nov 2024 10:14:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73A046587D;\n\tFri, 15 Nov 2024 11:13:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B9D86586A\n\tfor ;\n\tFri, 15 Nov 2024 11:13:48 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D2A0D9CE;\n\tFri, 15 Nov 2024 11:13:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bauTVhlG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731665614;\n\tbh=VpZC8PTz+1Nj554gevqPvU57r63g+PiZwc9DzX0/NkM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bauTVhlG7kCu5Re1FRELo38R6oYsEDk0emK96NX3qB7XcOFK8Vio4ywa/OwKMIy87\n\tpTnHkPk7TXi7ffOR46Yc9pQKn1EQAmNmSmhwqGTBPo7NzO9jkEavO4/qhQfTXfaSDy\n\tXKastdLXwHCYFREHULZem7WJsza2nZLSD6cuts+4=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Anthony.McGivern@arm.com, Daniel Scally ,\n\tUmang Jain ,\n\tKieran Bingham ,\n\tJacopo Mondi ","Subject":"[PATCH v6 03/14] libcamera: mali-c55: Init camera properties","Date":"Fri, 15 Nov 2024 10:13:23 +0000","Message-Id":"<20241115101334.453104-4-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241115101334.453104-1-dan.scally@ideasonboard.com>","References":"<20241115101334.453104-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialise the camera properties using the CameraSensor properties.\n\nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\nChanges in v6:\n\n\t- None\n\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 44f56ab7..80cd98b3 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -964,7 +964,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties and controls. */\n+\t\tdata->properties_ = data->sensor_->properties();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n \t}\n","prefixes":["v6","03/14"]}