{"id":2185,"url":"https://patchwork.libcamera.org/api/1.1/patches/2185/?format=json","web_url":"https://patchwork.libcamera.org/patch/2185/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","date":"2019-10-13T23:27:49","name":"[libcamera-devel,03/10] libcamera: controls: Prevent copies of ControlId class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"958455f068cbe7e34ddaf818052f9eaee4dba7ba","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2185/mbox/","series":[{"id":534,"url":"https://patchwork.libcamera.org/api/1.1/series/534/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=534","date":"2019-10-13T23:27:46","name":"Merge V4L2ControlInfoMap and ControlInfoMap","version":1,"mbox":"https://patchwork.libcamera.org/series/534/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2185/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2185/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF4636196E\n\tfor ;\n\tMon, 14 Oct 2019 01:28:03 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F1C933A\n\tfor ;\n\tMon, 14 Oct 2019 01:28:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571009283;\n\tbh=q/SCJ6Yq4hXUsx5bb0H6QxnjzRdVXL9/wz89SxmhqHo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pKQGCvDg99q6jiSmrx6KcWnT85w/BssSSsERKrvI4u3rf5qLF8sCGarMnFj2PM/Vv\n\tQYAU8WsDmdxphby0EVUfbSUuRh89GYTE+r28Dkm/fJyczKj7RqEq3tNwvEBAsDE1kk\n\trXB8Q4bJTLU0ZeRVWJvdVIHOLSc3DXuuIhopPyZM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 14 Oct 2019 02:27:49 +0300","Message-Id":"<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>","References":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 03/10] libcamera: controls: Prevent copies\n\tof ControlId class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 23:28:04 -0000"},"content":"Now that the V4L2ControlId embedded in V4L2ControlInfo has been moved\nout and doesn't require to be copied anymore, the base ControlId class\ndoesn't need to be copyable either. Delete the ControlId copy\nconstructor and copy assignment operator.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/controls.h | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ebc4204f98fd..5534a2edb567 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -68,12 +68,11 @@ protected:\n \t\t: id_(id), name_(name), type_(type)\n \t{\n \t}\n-#ifndef __DOXYGEN__\n-\tControlId &operator=(const ControlId &) = default;\n-\tControlId(const ControlId &) = default;\n-#endif\n \n private:\n+\tControlId &operator=(const ControlId &) = delete;\n+\tControlId(const ControlId &) = delete;\n+\n \tunsigned int id_;\n \tstd::string name_;\n \tControlType type_;\n","prefixes":["libcamera-devel","03/10"]}