{"id":21842,"url":"https://patchwork.libcamera.org/api/1.1/patches/21842/?format=json","web_url":"https://patchwork.libcamera.org/patch/21842/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241107105846.52287-10-dan.scally@ideasonboard.com>","date":"2024-11-07T10:58:42","name":"[v5,09/13] libcamera: mali-c55: Propagate CSI-2 format to ISP","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7b5b02f085acde7933ac317a1cef7eb6eabfda79","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21842/mbox/","series":[{"id":4776,"url":"https://patchwork.libcamera.org/api/1.1/series/4776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4776","date":"2024-11-07T10:58:33","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":5,"mbox":"https://patchwork.libcamera.org/series/4776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21842/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21842/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2A3AC32CE\n\tfor ;\n\tThu, 7 Nov 2024 10:59:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2935E65497;\n\tThu, 7 Nov 2024 11:59:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFACF6546E\n\tfor ;\n\tThu, 7 Nov 2024 11:58:56 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06DED5B3;\n\tThu, 7 Nov 2024 11:58:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RqcPauF6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977128;\n\tbh=0ycJPOLaeKCRjeRdYS01ObExY/Y2R7GR/l7TPhxFvyk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RqcPauF6nGcUyugvMh056iIaxdaO+Qc0vzq4scQJguXfjknnlYvBxvCsLCs83CH6D\n\tW1z8Di+u+UpiUyA47kKhT7vmnqL8GalbbIEy/f4VpM1gm0SWUKjqnDVi5aTlMLfBud\n\tRZhgr1pW99Ttql5nUKndyVzgqYpLjmmx1C9lpez4=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tUmang Jain ","Subject":"[PATCH v5 09/13] libcamera: mali-c55: Propagate CSI-2 format to ISP","Date":"Thu, 7 Nov 2024 10:58:42 +0000","Message-Id":"<20241107105846.52287-10-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","References":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nThe latest version of the Mali C55 driver has changed the format\naccepted by the ISP sink pad to be the 20-bit wide.\n\nThe CSI-2 receiver handles the format expansion internally by\npropagating the sensor produced format from its sink to the 20-bit\nexpanded version on its source pad.\n\nInstead of re-applying the sensor format to the CSI-2 receiver source\npad (which is now an invalid operation) read from there the format\npropagated by the driver internally and further propagate it to the ISP\nsubdevice.\n\nReviewed-by: Daniel Scally \nReviewed-by: Umang Jain \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 28ad0172..156560c1 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -768,7 +768,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tif (ret)\n \t\t\treturn ret;\n \n-\t\tret = data->csi_->setFormat(1, &subdevFormat);\n+\t\tret = data->csi_->getFormat(1, &subdevFormat);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n","prefixes":["v5","09/13"]}