{"id":21836,"url":"https://patchwork.libcamera.org/api/1.1/patches/21836/?format=json","web_url":"https://patchwork.libcamera.org/patch/21836/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241107105846.52287-4-dan.scally@ideasonboard.com>","date":"2024-11-07T10:58:36","name":"[v5,03/13] libcamera: mali-c55: Init camera properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1aca73ed991770979887e9913c105c729c720980","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21836/mbox/","series":[{"id":4776,"url":"https://patchwork.libcamera.org/api/1.1/series/4776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4776","date":"2024-11-07T10:58:33","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":5,"mbox":"https://patchwork.libcamera.org/series/4776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21836/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21836/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E215DBE173\n\tfor ;\n\tThu, 7 Nov 2024 10:59:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6895665466;\n\tThu, 7 Nov 2024 11:58:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C52666546F\n\tfor ;\n\tThu, 7 Nov 2024 11:58:54 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D16519FF;\n\tThu, 7 Nov 2024 11:58:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ua6G3QJl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977126;\n\tbh=mvqwLnfycSikUqNwIF1bgP1TqjfUKa/Ao6De+Nr10S4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ua6G3QJlhYDHBbftDaR/I4soMgvQZtpR6hFsKN9hpnaT5G/U1GRF5Uajv0/ptCcwH\n\tYA6JG7gTaA6ok0oKRo2jrQyEfhJTilZa7xLtnQAfKH+0P4NLOf6ZQUHjMhAU7o5/SX\n\tCFEfzR7S7a6s45PIcn7DikBKWyMOkJX3bq3oP7C8=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tUmang Jain ,\n\tKieran Bingham ,\n\tJacopo Mondi ","Subject":"[PATCH v5 03/13] libcamera: mali-c55: Init camera properties","Date":"Thu, 7 Nov 2024 10:58:36 +0000","Message-Id":"<20241107105846.52287-4-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","References":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialise the camera properties using the CameraSensor properties.\n\nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex d1ae1a61..bffd842c 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties and controls. */\n+\t\tdata->properties_ = data->sensor_->properties();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n \t}\n","prefixes":["v5","03/13"]}