{"id":21810,"url":"https://patchwork.libcamera.org/api/1.1/patches/21810/?format=json","web_url":"https://patchwork.libcamera.org/patch/21810/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241105014949.32244-2-laurent.pinchart@ideasonboard.com>","date":"2024-11-05T01:49:48","name":"[1/2] test: py: Replace environment array with environment object","commit_ref":"b3eba172130d1bbde882ddd0aeb32f1b3c1689ab","pull_url":null,"state":"accepted","archived":false,"hash":"9982ab7aa68f59e8233194e86e26fe8031c13378","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21810/mbox/","series":[{"id":4768,"url":"https://patchwork.libcamera.org/api/1.1/series/4768/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4768","date":"2024-11-05T01:49:47","name":"test: py: Fix unit test error with ASan","version":1,"mbox":"https://patchwork.libcamera.org/series/4768/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21810/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21810/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC41FBDB1C\n\tfor ;\n\tTue, 5 Nov 2024 01:50:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 019F3653EA;\n\tTue, 5 Nov 2024 02:49:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAE74653E1\n\tfor ;\n\tTue, 5 Nov 2024 02:49:57 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 825E87FE;\n\tTue, 5 Nov 2024 02:49:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jlcYLLUX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730771390;\n\tbh=hEHwB4Y0gWKIHiwMbuvuyIqKPvV/Ukmub82lOi18xDo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jlcYLLUX4s6kyGzU468/HiS3inNE3FVsPUntnPKXqgxuFrqz2ZJyhw6mKi0xkD4yN\n\towWtQ5m1fFWBQ4gnK+SWlTjzPrIScoHV2Z//QVgfWTpjHTSHJgiZpSin/XaPEuCwHa\n\tZmxuidsUNB3WKt5C+VlwD8/eSKaXtq56hc+TxGGI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Tomi Valkeinen ","Subject":"[PATCH 1/2] test: py: Replace environment array with environment\n\tobject","Date":"Tue, 5 Nov 2024 03:49:48 +0200","Message-ID":"<20241105014949.32244-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241105014949.32244-1-laurent.pinchart@ideasonboard.com>","References":"<20241105014949.32244-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The environment for pyunittests is stored in an array. Meson provides an\nenvironment object, which makes handling of multi-value environment\nvariables easier and increases code clarity. Switch to using the\nenvironment object.\n\nSigned-off-by: Laurent Pinchart \n---\n test/py/meson.build | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/test/py/meson.build b/test/py/meson.build\nindex 0b679d31ff34..481bb481c110 100644\n--- a/test/py/meson.build\n+++ b/test/py/meson.build\n@@ -13,15 +13,19 @@ if asan_runtime_missing\n subdir_done()\n endif\n \n+py_env = environment()\n+\n pymod = import('python')\n py3 = pymod.find_installation('python3')\n \n pypathdir = meson.project_build_root() / 'src' / 'py'\n-py_env = ['PYTHONPATH=' + pypathdir]\n+py_env.append('PYTHONPATH', pypathdir)\n \n if asan_enabled\n+ py_env.append('LD_PRELOAD', asan_runtime)\n+\n # Disable leak detection as the Python interpreter is full of leaks.\n- py_env += ['LD_PRELOAD=' + asan_runtime, 'ASAN_OPTIONS=detect_leaks=0']\n+ py_env.append('ASAN_OPTIONS', 'detect_leaks=0')\n endif\n \n test('pyunittests',\n","prefixes":["1/2"]}