{"id":21794,"url":"https://patchwork.libcamera.org/api/1.1/patches/21794/?format=json","web_url":"https://patchwork.libcamera.org/patch/21794/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241031160741.253855-5-dan.scally@ideasonboard.com>","date":"2024-10-31T16:07:39","name":"[4/6] ipa: rpi: Use centralised libipa helpers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8eff4bf77699566d499271706494971febb8b819","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21794/mbox/","series":[{"id":4762,"url":"https://patchwork.libcamera.org/api/1.1/series/4762/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4762","date":"2024-10-31T16:07:35","name":"Centralise common functions in IPA modules","version":1,"mbox":"https://patchwork.libcamera.org/series/4762/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21794/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21794/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1486C330C\n\tfor ;\n\tThu, 31 Oct 2024 16:08:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 001BC653AE;\n\tThu, 31 Oct 2024 17:08:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76A3B6039B\n\tfor ;\n\tThu, 31 Oct 2024 17:08:13 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67A389EC;\n\tThu, 31 Oct 2024 17:08:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hp3+a+lj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730390889;\n\tbh=bIL2KgAsCqAOa2Ukgp1a7gZ0S/dFA59FTfmODvATBhY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hp3+a+ljOMk7dkShvZKe4qrqXY0j9qxY561XOqILz0Qpnslgs4zaCtPqI4Karp2/y\n\tpCJ4BheCGMH3dfh9JFFBr0gaR7+hFI9Flv7/Z5tOGgWfZWI/P4KXLLb7kyDKwWdplv\n\tns9gWwfGf3z14StP7WjuLJ1QZsyynPYIgrFNcypA=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"mike.rudenko@gmail.com,\n\tDaniel Scally ","Subject":"[PATCH 4/6] ipa: rpi: Use centralised libipa helpers","Date":"Thu, 31 Oct 2024 16:07:39 +0000","Message-Id":"<20241031160741.253855-5-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241031160741.253855-1-dan.scally@ideasonboard.com>","References":"<20241031160741.253855-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the centralised libipa helpers rather than open coding common\nfunctions.\n\nSigned-off-by: Daniel Scally \n---\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex c9df9b5b..0c8252a0 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -12,6 +12,8 @@\n \n #include \n \n+#include \"libipa/helpers.h\"\n+\n #include \"../awb_status.h\"\n #include \"../device_status.h\"\n #include \"../histogram.h\"\n@@ -694,11 +696,11 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,\n \tdouble ySum;\n \t/* Factor in the AWB correction if needed. */\n \tif (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb) {\n-\t\tySum = rSum * awb.gainR * .299 +\n-\t\t gSum * awb.gainG * .587 +\n-\t\t bSum * awb.gainB * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum * awb.gainR,\n+\t\t\t\t\t\t gSum * awb.gainG,\n+\t\t\t\t\t\t bSum * awb.gainB);\n \t} else\n-\t\tySum = rSum * .299 + gSum * .587 + bSum * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum, gSum, bSum);\n \n \treturn ySum / pixelSum / (1 << 16);\n }\n","prefixes":["4/6"]}