{"id":21694,"url":"https://patchwork.libcamera.org/api/1.1/patches/21694/?format=json","web_url":"https://patchwork.libcamera.org/patch/21694/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241018160638.936993-4-stefan.klug@ideasonboard.com>","date":"2024-10-18T16:06:32","name":"[v4,3/4] libcamera: controls: Add missing size to control_type","commit_ref":"ed3f3f6aa6f2dded584e1b3d3f97e8bceea1b2cd","pull_url":null,"state":"accepted","archived":false,"hash":"041b78b891cd135d0c0d1f032ba5d6956e011fd4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21694/mbox/","series":[{"id":4722,"url":"https://patchwork.libcamera.org/api/1.1/series/4722/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4722","date":"2024-10-18T16:06:29","name":"A few small fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/4722/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21694/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21694/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AF72C32FE\n\tfor ;\n\tFri, 18 Oct 2024 16:06:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5C2765394;\n\tFri, 18 Oct 2024 18:06:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AAF16538A\n\tfor ;\n\tFri, 18 Oct 2024 18:06:51 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:77a0:ddb9:22bf:b8d9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C81D021C;\n\tFri, 18 Oct 2024 18:05:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PgMzpC8S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729267507;\n\tbh=kkl+vFfasWNR2zoP9t8OzWrHjLHX6T7+Hp4tzuJQ9CA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PgMzpC8Sm6AHklIUS0Gx736vg6dxOAs/EcpZjg4ZMEugnInx7o+NbPDV9TUmo0vFZ\n\trcqPnpuQFxzObXO+3m4wIQRhsK3NWf7ECyQGvYCxvYLmIi0O9OciVgr0lNQA6J1vCK\n\tBM+/3DPKtBIIvubx3gtUi1IaVX4VmuM0Tm7HAoJk=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[PATCH v4 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","Date":"Fri, 18 Oct 2024 18:06:32 +0200","Message-ID":"<20241018160638.936993-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241018160638.936993-1-stefan.klug@ideasonboard.com>","References":"<20241018160638.936993-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The size member is missing in control_type. This did not do any\nharm because the only control using the Point type was an array control.\nAs soon as a control-id with a non-array Point control gets defined, the\ncompile fails with:\n\nerror: size is not a member of libcamera::details::control_type\n\nFixes: 200d535ca85f (\"libcamera: controls: Add ControlTypePoint\")\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n\n---\nChanges in v2:\n- Describe the error in commit message\n- Collected tags\n---\n include/libcamera/controls.h | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ca60bbacad17..28fec767fae1 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -101,6 +101,7 @@ struct control_type {\n template<>\n struct control_type {\n \tstatic constexpr ControlType value = ControlTypePoint;\n+\tstatic constexpr std::size_t size = 0;\n };\n \n template\n","prefixes":["v4","3/4"]}