{"id":21631,"url":"https://patchwork.libcamera.org/api/1.1/patches/21631/?format=json","web_url":"https://patchwork.libcamera.org/patch/21631/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241015203820.574326-2-stefan.klug@ideasonboard.com>","date":"2024-10-15T20:38:12","name":"[v1,1/4] ipa: rkisp1: algorithms: agc: Check for correct stats type","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5dfae9b9e4f11040258972cc476fe0289d530761","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21631/mbox/","series":[{"id":4702,"url":"https://patchwork.libcamera.org/api/1.1/series/4702/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4702","date":"2024-10-15T20:38:11","name":"A few small fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/4702/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21631/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21631/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 040AEC326C\n\tfor ;\n\tTue, 15 Oct 2024 20:38:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 889536537E;\n\tTue, 15 Oct 2024 22:38:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2286765386\n\tfor ;\n\tTue, 15 Oct 2024 22:38:28 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:64d4:9f74:8308:300d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2533FA27;\n\tTue, 15 Oct 2024 22:36:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IPgi7wXM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729024606;\n\tbh=mBo6nreJkQ05/3D/+PPYIjLFWbmFj5QYpbHFKPKt6Zo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IPgi7wXMd6OVtEqtbOSiAyc7CkCqpM2YPvJ7wLBTdiksKzV3JZ9z3Tiwijsivkqlo\n\tP71lgAXL+F0BifT4hVdhg3FTwN7X9UxBVUUbz15K+To+SCSO8Ya/W2cb5dMz8zqtej\n\tXni6ky0DVTKr0cub3eDoUFCiKmTVdzfRnwDhjgDY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 1/4] ipa: rkisp1: algorithms: agc: Check for correct stats\n\ttype","Date":"Tue, 15 Oct 2024 22:38:12 +0200","Message-ID":"<20241015203820.574326-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241015203820.574326-1-stefan.klug@ideasonboard.com>","References":"<20241015203820.574326-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Sometimes the ISP produces statistics only with a subset of statistic\ntypes being valid. It doesn't happen often, but it happens. Check for\nthe RKISP1_CIF_ISP_STAT_AUTOEXP bit to prevent using invalid or outdated\ndata.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 17d074d9c03e..5683707fa91a 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -398,7 +398,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t\t IPAFrameContext &frameContext, const rkisp1_stat_buffer *stats,\n \t\t ControlList &metadata)\n {\n-\tif (!stats) {\n+\tif (!(stats && stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP)) {\n \t\tfillMetadata(context, frameContext, metadata);\n \t\treturn;\n \t}\n@@ -412,7 +412,6 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t */\n \n \tconst rkisp1_cif_isp_stat *params = &stats->params;\n-\tASSERT(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP);\n \n \t/* The lower 4 bits are fractional and meant to be discarded. */\n \tHistogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n","prefixes":["v1","1/4"]}