{"id":21599,"url":"https://patchwork.libcamera.org/api/1.1/patches/21599/?format=json","web_url":"https://patchwork.libcamera.org/patch/21599/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241011182800.1750589-3-mzamazal@redhat.com>","date":"2024-10-11T18:27:57","name":"[v3,2/4] ipa: ipu3: Add constructor to the IPA context","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c75c0d5ba6058dd0a4abdb11b3a028e4e965ebdb","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21599/mbox/","series":[{"id":4688,"url":"https://patchwork.libcamera.org/api/1.1/series/4688/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4688","date":"2024-10-11T18:27:55","name":"Add contrast control to software ISP","version":3,"mbox":"https://patchwork.libcamera.org/series/4688/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21599/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21599/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 332E5C3260\n\tfor ;\n\tFri, 11 Oct 2024 18:28:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A158765397;\n\tFri, 11 Oct 2024 20:28:17 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C175E6538F\n\tfor ;\n\tFri, 11 Oct 2024 20:28:13 +0200 (CEST)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-691-VzN56SJqN3-kyttU2cHVzw-1;\n\tFri, 11 Oct 2024 14:28:11 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 6457819560B4; Fri, 11 Oct 2024 18:28:09 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.99])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1F49530001A3; Fri, 11 Oct 2024 18:28:07 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"DuZHG2wP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1728671292;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=vcWWl0EayfxYL30pWGVzokrFwez0G1xHkt6c+5ONs58=;\n\tb=DuZHG2wPoNyIJ/QYtVbnrDNbhuSkbCrH+mFYJx2deux/8PXNKIvxYx4TE3Jarmjrdx9Y6o\n\tRz7l3YKRUcEP3pMCcQH52XDntx/dAlNgYr4pOURHNiHDtl/aCr86GaP758GF33FJp5jWMG\n\t+oM7IYLV/v+K3LtHjIp12YZGEMcPCNE=","X-MC-Unique":"VzN56SJqN3-kyttU2cHVzw-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v3 2/4] ipa: ipu3: Add constructor to the IPA context","Date":"Fri, 11 Oct 2024 20:27:57 +0200","Message-ID":"<20241011182800.1750589-3-mzamazal@redhat.com>","In-Reply-To":"<20241011182800.1750589-1-mzamazal@redhat.com>","References":"<20241011182800.1750589-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's have a constructor that takes just the non-default argument,\nwithout the need to specify the defaults.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/ipu3/ipa_context.cpp | 4 ++++\n src/ipa/ipu3/ipa_context.h | 5 +++++\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 917d06541..76eeb52fe 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -39,6 +39,10 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAContext\n * \\brief Global IPA context data shared between all algorithms\n *\n+ * \\fn IPAContext::IPAContext\n+ * \\brief Initialize the instance with the given number of frame contexts\n+ * \\param[in] frameContextSize Size of the frame context ring buffer\n+ *\n * \\var IPAContext::configuration\n * \\brief The IPA session configuration, immutable during the session\n *\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex c85d1e34e..24f51a296 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -84,6 +84,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 10a8c86d8..938bc8228 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -187,7 +187,7 @@ private:\n };\n \n IPAIPU3::IPAIPU3()\n-\t: context_({ {}, {}, { kMaxFrameContexts }, {} })\n+\t: context_(kMaxFrameContexts)\n {\n }\n \n","prefixes":["v3","2/4"]}