{"id":21573,"url":"https://patchwork.libcamera.org/api/1.1/patches/21573/?format=json","web_url":"https://patchwork.libcamera.org/patch/21573/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241009200110.275544-3-hdegoede@redhat.com>","date":"2024-10-09T20:01:08","name":"[RFC,2/4] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/1.1/people/102/?format=json","name":"Hans de Goede","email":"hdegoede@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21573/mbox/","series":[{"id":4678,"url":"https://patchwork.libcamera.org/api/1.1/series/4678/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4678","date":"2024-10-09T20:01:06","name":"libcamera: swstats_cpu: Add processFrame() method","version":1,"mbox":"https://patchwork.libcamera.org/series/4678/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21573/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21573/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDF38C32DE\n\tfor ;\n\tWed, 9 Oct 2024 20:01:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62B9065372;\n\tWed, 9 Oct 2024 22:01:22 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12F786536B\n\tfor ;\n\tWed, 9 Oct 2024 22:01:19 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-13-hPwsmGXMP96nIT8q20Dh5A-1;\n\tWed, 09 Oct 2024 16:01:17 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid CE3F51955F3C for ;\n\tWed, 9 Oct 2024 20:01:16 +0000 (UTC)","from shalem.redhat.com (unknown [10.39.192.36])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 41FC519560A3; Wed, 9 Oct 2024 20:01:15 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WtQRnGKM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1728504079;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=SLSJbkHo4J3x1hu/xtFmdmFjYqjtsG7ZjRZn96G8SRw=;\n\tb=WtQRnGKM9RV6UYTxo3Ria7GyH+dcoxn/wKdJo5EEd3xZZfi1QLjsSSsIIHsnvAxV4CsmNe\n\tQHDvJ0MnORvXh8+OcyRTuhnyl4NM+CpESTWuPq3tEUKaWvcIiAHpQgWGzyDUGkKIrUpemC\n\tNKHapDiQ0V/0DnkIvEP4frzxvfOldVw=","X-MC-Unique":"hPwsmGXMP96nIT8q20Dh5A-1","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Maxime Ripard , \n\tHans de Goede ","Subject":"[RFC 2/4] libcamera: swstats_cpu: Drop patternSize_ documentation","Date":"Wed, 9 Oct 2024 22:01:08 +0200","Message-ID":"<20241009200110.275544-3-hdegoede@redhat.com>","In-Reply-To":"<20241009200110.275544-1-hdegoede@redhat.com>","References":"<20241009200110.275544-1-hdegoede@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"patternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nSigned-off-by: Hans de Goede \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex a9a3e77a..5e4246a9 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -112,13 +114,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["RFC","2/4"]}