{"id":21542,"url":"https://patchwork.libcamera.org/api/1.1/patches/21542/?format=json","web_url":"https://patchwork.libcamera.org/patch/21542/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241008153031.429906-5-stefan.klug@ideasonboard.com>","date":"2024-10-08T15:29:42","name":"[v3,4/7] ipa: rkisp1: Add constructor to the ipa context","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"64287d4f9856023beb60bee4ceb56f93a3473a72","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21542/mbox/","series":[{"id":4667,"url":"https://patchwork.libcamera.org/api/1.1/series/4667/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4667","date":"2024-10-08T15:29:38","name":"Add support for IPA debugging metadata","version":3,"mbox":"https://patchwork.libcamera.org/series/4667/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21542/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21542/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9677BE080\n\tfor ;\n\tTue, 8 Oct 2024 15:30:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C8986536D;\n\tTue, 8 Oct 2024 17:30:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 631EC65363\n\tfor ;\n\tTue, 8 Oct 2024 17:30:47 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d:f30b:aa60:fabf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5123514;\n\tTue, 8 Oct 2024 17:29:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rMB5Cc5I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728401350;\n\tbh=FGj48CRnmw837TOdKjFASRFcdEff4M7K5Azl/VJ6KuU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rMB5Cc5ID16BHAgqm1Y1HN6jMF9ykK/xk6nxTDuoKYeCw/hepsjRLm53Dekzk0pvk\n\t3SmnYGqbhtbaEjguoLl8oDGU7Jf1LqVnZ+KfV+0oefJGaBAjF6/RpN4HfQ5uej0+2l\n\t9YCgD50ddD04r3pNtllj6HU6/2Qax9IuHM4VHJso=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v3 4/7] ipa: rkisp1: Add constructor to the ipa context","Date":"Tue, 8 Oct 2024 17:29:42 +0200","Message-ID":"<20241008153031.429906-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>","References":"<20241008153031.429906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialization using the initializer list is cumbersome and requires\nmodifications to the list whenever the context is modified. Fix that by\nadding a proper constructor to the context.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/ipa/rkisp1/ipa_context.h | 5 +++++\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n 2 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex e274d9b01e1c..d52e73ad2503 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -180,6 +180,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: hw(nullptr), frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tconst IPAHwSettings *hw;\n \tIPACameraSensorInfo sensorInfo;\n \tIPASessionConfiguration configuration;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 9e161cabdea4..a579f21de56f 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n } /* namespace */\n \n IPARkISP1::IPARkISP1()\n-\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n+\t: context_(kMaxFrameContexts)\n {\n }\n \n","prefixes":["v3","4/7"]}