{"id":21527,"url":"https://patchwork.libcamera.org/api/1.1/patches/21527/?format=json","web_url":"https://patchwork.libcamera.org/patch/21527/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241007095425.211158-5-stefan.klug@ideasonboard.com>","date":"2024-10-07T09:54:08","name":"[v2,4/7] ipa: rkisp1: Add constructor to the ipa context","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"64287d4f9856023beb60bee4ceb56f93a3473a72","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21527/mbox/","series":[{"id":4661,"url":"https://patchwork.libcamera.org/api/1.1/series/4661/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4661","date":"2024-10-07T09:54:04","name":"Add support for IPA debugging metadata","version":2,"mbox":"https://patchwork.libcamera.org/series/4661/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21527/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21527/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6C31C3264\n\tfor ;\n\tMon, 7 Oct 2024 09:54:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32F636353A;\n\tMon, 7 Oct 2024 11:54:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77F0A63535\n\tfor ;\n\tMon, 7 Oct 2024 11:54:42 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ba12:1296:516b:1122])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F03A1111;\n\tMon, 7 Oct 2024 11:53:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"akvc92Xy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728294786;\n\tbh=FGj48CRnmw837TOdKjFASRFcdEff4M7K5Azl/VJ6KuU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=akvc92XyQWpnl30PdEW1ownc13N3Ih7Ijt6zmlMwtdXPDU9oc/cHCb6MZDKHOwb4H\n\tTLP7rMFBEPP9+R0A+bUOiJ1yxj5dDM/8hkHJ58B/A0mgQd+ebkSoCmNIurJE3E2+Fh\n\tNOw4mXtS3orL0x63ILuQfKn+9hWYzkgtpYSMRz7A=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v2 4/7] ipa: rkisp1: Add constructor to the ipa context","Date":"Mon, 7 Oct 2024 11:54:08 +0200","Message-ID":"<20241007095425.211158-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241007095425.211158-1-stefan.klug@ideasonboard.com>","References":"<20241007095425.211158-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialization using the initializer list is cumbersome and requires\nmodifications to the list whenever the context is modified. Fix that by\nadding a proper constructor to the context.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/ipa/rkisp1/ipa_context.h | 5 +++++\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n 2 files changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex e274d9b01e1c..d52e73ad2503 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -180,6 +180,11 @@ struct IPAFrameContext : public FrameContext {\n };\n \n struct IPAContext {\n+\tIPAContext(unsigned int frameContextSize)\n+\t\t: hw(nullptr), frameContexts(frameContextSize)\n+\t{\n+\t}\n+\n \tconst IPAHwSettings *hw;\n \tIPACameraSensorInfo sensorInfo;\n \tIPASessionConfiguration configuration;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 9e161cabdea4..a579f21de56f 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -124,7 +124,7 @@ const ControlInfoMap::Map rkisp1Controls{\n } /* namespace */\n \n IPARkISP1::IPARkISP1()\n-\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n+\t: context_(kMaxFrameContexts)\n {\n }\n \n","prefixes":["v2","4/7"]}