{"id":21479,"url":"https://patchwork.libcamera.org/api/1.1/patches/21479/?format=json","web_url":"https://patchwork.libcamera.org/patch/21479/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241002161933.247091-9-stefan.klug@ideasonboard.com>","date":"2024-10-02T16:19:26","name":"[v1,8/8,WIP] ipa: enable debug metadata by default","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3afb3d5a57108c56ada2e63b379f56dce02b531b","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21479/mbox/","series":[{"id":4648,"url":"https://patchwork.libcamera.org/api/1.1/series/4648/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4648","date":"2024-10-02T16:19:18","name":"Add support for IPA debugging metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/4648/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21479/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21479/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49039BD80A\n\tfor ;\n\tWed, 2 Oct 2024 16:20:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A4A363532;\n\tWed, 2 Oct 2024 18:20:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A48916352F\n\tfor ;\n\tWed, 2 Oct 2024 18:20:40 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b246:b33f:c662:8ae1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4F42320D;\n\tWed, 2 Oct 2024 18:19:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kSp4vuln\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727885947;\n\tbh=KGv6J3Mw1x+xm5eUkpBW6wbhUyCGGCzzrLzCj7zFk9Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kSp4vulnGx8bBcQGjzT0vl9JI0p7lBOI9C9RYURTil2Bi96lY/CBChugribxxgmC4\n\tCNNEPmpCvQxBQTylD/oUhXHec+EGQjV0e25h59RBGuQxMXwhrtS24EMs108Inv1X05\n\tQfUYWhNT8+Bz3TiMK/xHVqXqumqCPG3HbuH4oNac=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 8/8] [WIP] ipa: enable debug metadata by default","Date":"Wed, 2 Oct 2024 18:19:26 +0200","Message-ID":"<20241002161933.247091-9-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>","References":"<20241002161933.247091-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Camshark currently doesn't support metadata values that are not there on\nevery frame. Enable the debug metadata by default to test this series.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/rkisp1.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 5b1ef0c372c6..fc95f733a2e8 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -328,6 +328,11 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n \tcontext_.debugMetadata.checkForEnable(controls);\n+\t/*\n+\t * Todo: Remove the unconditional enable as soon as camshark supports\n+\t * metadata that is not available on every frame\n+\t */\n+\tcontext_.debugMetadata.enable();\n \n \tfor (auto const &a : algorithms()) {\n \t\tAlgorithm *algo = static_cast(a.get());\n","prefixes":["v1","8/8","WIP"]}