{"id":21462,"url":"https://patchwork.libcamera.org/api/1.1/patches/21462/?format=json","web_url":"https://patchwork.libcamera.org/patch/21462/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241001102810.479285-15-mzamazal@redhat.com>","date":"2024-10-01T10:28:06","name":"[v5,14/15] libcamera: software_isp: Make input buffer copying configurable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5d1fc4607402a09bcaf8e54a0dd8ae46c8c17543","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21462/mbox/","series":[{"id":4644,"url":"https://patchwork.libcamera.org/api/1.1/series/4644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4644","date":"2024-10-01T10:27:52","name":"Add global configuration file","version":5,"mbox":"https://patchwork.libcamera.org/series/4644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21462/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21462/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A704CC3263\n\tfor ;\n\tTue, 1 Oct 2024 10:29:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB44565369;\n\tTue, 1 Oct 2024 12:28:59 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C8D36536A\n\tfor ;\n\tTue, 1 Oct 2024 12:28:50 +0200 (CEST)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-314-fNjtr-noPwapNmnUxGwC3w-1;\n\tTue, 01 Oct 2024 06:28:45 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 524F91943CDE; Tue, 1 Oct 2024 10:28:42 +0000 (UTC)","from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1329F1944B21; Tue, 1 Oct 2024 10:28:40 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UvEIUpi+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727778528;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=djaF4ioQPboODZ5hkKQdEePHjfoR/S/KRGUUL1rmaJQ=;\n\tb=UvEIUpi+n/3t4hruSt5C83B6j3tTsK2unCvbYnt1uSvMzSfhGbDUYsneXFcrrV6ceVwXpi\n\tRWDAX/TgMlkEM8K+25dI1Jij5EezjF3ix+3fOt1PKt7CF37AJtRVddrO1PhXnDeF65B524\n\t+NWywhJWV7PgM087HCI5tMeH2EFL0Ic=","X-MC-Unique":"fNjtr-noPwapNmnUxGwC3w-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"[PATCH v5 14/15] libcamera: software_isp: Make input buffer copying\n\tconfigurable","Date":"Tue, 1 Oct 2024 12:28:06 +0200","Message-ID":"<20241001102810.479285-15-mzamazal@redhat.com>","In-Reply-To":"<20241001102810.479285-1-mzamazal@redhat.com>","References":"<20241001102810.479285-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"On some platforms, working directly on the input buffer is very slow due\nto disabled caching. This is why we copy the input buffer into standard\n(cached) memory. This is an unnecessary overhead on platforms with\ncached buffers.\n\nLet's make input buffer copying configurable. The default is still\ncopying, as it's overhead is much lower than contingent operations on\nnon-cached memory. Ideally, we should improve this in future to set the\ndefault to non-copying if we can be sure under observable circumstances\nthat we are working with cached buffers.\n\nCompletes software ISP TODO #6.\n\nSigned-off-by: Milan Zamazal \n---\n Documentation/runtime_configuration.rst | 2 ++\n src/libcamera/software_isp/TODO | 11 -----------\n src/libcamera/software_isp/debayer_cpu.cpp | 5 ++++-\n 3 files changed, 6 insertions(+), 12 deletions(-)","diff":"diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\nindex 819b1c830..4babce1ab 100644\n--- a/Documentation/runtime_configuration.rst\n+++ b/Documentation/runtime_configuration.rst\n@@ -55,6 +55,7 @@ file structure:\n - CAMERA-ID:\n tuning-file: # full path\n simple:\n+ copy_input_buffer: # true/false\n supported_devices:\n - driver: # driver name, e.g. `mxc-isi`\n software_isp: # true/false\n@@ -87,6 +88,7 @@ Configuration file example\n rpi:\n config_file: /usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml\n simple:\n+ copy_input_buffer: false\n supported_devices:\n - driver: mxc-isi\n software_isp: true\ndiff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\nindex a50db668e..2c919f442 100644\n--- a/src/libcamera/software_isp/TODO\n+++ b/src/libcamera/software_isp/TODO\n@@ -71,17 +71,6 @@ per-frame buffers like we do for hardware ISPs.\n \n ---\n \n-6. Input buffer copying configuration\n-\n-> DebayerCpu::DebayerCpu(std::unique_ptr stats)\n-> \t: stats_(std::move(stats)), gammaCorrection_(1.0)\n-> {\n-> \tenableInputMemcpy_ = true;\n-\n-Set this appropriately and/or make it configurable.\n-\n----\n-\n 7. Performance measurement configuration\n \n > void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex cf5ecdf7a..ca62c370b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -21,6 +21,7 @@\n \n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/framebuffer.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\n \n namespace libcamera {\n@@ -47,7 +48,9 @@ DebayerCpu::DebayerCpu(std::unique_ptr stats)\n \t * always set it to true as the safer choice but this should be changed in\n \t * future.\n \t */\n-\tenableInputMemcpy_ = true;\n+\tenableInputMemcpy_ = GlobalConfiguration::option(\n+\t\t\t\t \"pipelines.simple.copy_input_buffer\")\n+\t\t\t\t .value_or(true);\n \n \t/* Initialize color lookup tables */\n \tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++)\n","prefixes":["v5","14/15"]}