{"id":21458,"url":"https://patchwork.libcamera.org/api/1.1/patches/21458/?format=json","web_url":"https://patchwork.libcamera.org/patch/21458/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241001102810.479285-13-mzamazal@redhat.com>","date":"2024-10-01T10:28:04","name":"[v5,12/15] config: Allow enabling software ISP in runtime","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7181b394ad2e32d4b5e4abb52594fab8e39fff40","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21458/mbox/","series":[{"id":4644,"url":"https://patchwork.libcamera.org/api/1.1/series/4644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4644","date":"2024-10-01T10:27:52","name":"Add global configuration file","version":5,"mbox":"https://patchwork.libcamera.org/series/4644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21458/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21458/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CD29C32DB\n\tfor ;\n\tTue, 1 Oct 2024 10:28:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C18AF6353B;\n\tTue, 1 Oct 2024 12:28:52 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F34DE63533\n\tfor ;\n\tTue, 1 Oct 2024 12:28:41 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-644-ubYYyyvtMM2FCWLQhFB7Uw-1;\n\tTue, 01 Oct 2024 06:28:40 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 14D7619626EB; Tue, 1 Oct 2024 10:28:39 +0000 (UTC)","from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BB30D1956054; Tue, 1 Oct 2024 10:28:37 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"US/FNkp+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727778520;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=H+QBcwH92CLmjNsNhkRdCPv9Mx+Qa+DP8zR5OLS/PbA=;\n\tb=US/FNkp+d6f13lqxDSvwbQ/KX4N1DarK/a6IHN8ZpKn74i+JQQK5/I1FJ/u9VL5sKbeTvv\n\tF5/7FG+YuKGt+wXMRpBDzk/uR6uJ91gUiUZh4x64CjpR2fnvQ5pIlc8In+/oHWIFKQE3wc\n\tzbyWTCVjby8d1PxupiHKMpzCDCzgD/s=","X-MC-Unique":"ubYYyyvtMM2FCWLQhFB7Uw-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ,\n\tNaushir Patuck ","Subject":"[PATCH v5 12/15] config: Allow enabling software ISP in runtime","Date":"Tue, 1 Oct 2024 12:28:04 +0200","Message-ID":"<20241001102810.479285-13-mzamazal@redhat.com>","In-Reply-To":"<20241001102810.479285-1-mzamazal@redhat.com>","References":"<20241001102810.479285-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch allows enabling or disabling software ISP in runtime in\naddition to compile time. This can be useful for software ISP testing\non various platforms as well as for overriding the defaults in case the\ndefaults don't work well (e.g. hardware ISP may or may not work on\ni.MX8MP depending on the kernel and libcamera patches present in the\ngiven system).\n\nThe configuration is specified as follows:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: DRIVER-NAME\n software_isp: BOOLEAN\n - ...\n\nFor example:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: mxc-isi\n software_isp: true\n\nThe overall configuration of enabling or disabling software ISP may get\ndropped in future but this patch is still useful in the meantime.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 3ddce71d3..81d8001b3 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -34,6 +34,7 @@\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/software_isp/software_isp.h\"\n@@ -1567,6 +1568,17 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t}\n \n \tswIspEnabled_ = info->swIspEnabled;\n+\tfor (GlobalConfiguration::Configuration entry :\n+\t GlobalConfiguration::configuration()\n+\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t\t\t .asList()) {\n+\t\tauto name = entry[\"driver\"].get();\n+\t\tif (name == info->driver) {\n+\t\t\tswIspEnabled_ = entry[\"software_isp\"].get().value_or(swIspEnabled_);\n+\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector sensors = locateSensors(media);\n","prefixes":["v5","12/15"]}