{"id":214,"url":"https://patchwork.libcamera.org/api/1.1/patches/214/?format=json","web_url":"https://patchwork.libcamera.org/patch/214/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190112141436.1562-3-jacopo@jmondi.org>","date":"2019-01-12T14:14:35","name":"[libcamera-devel,v3,2/3] test: media_device: Make MediaDeviceTest a MediaDevicePrintTest","commit_ref":"d85767a8c82df0ad8530800172d7bae4f837d6d8","pull_url":null,"state":"accepted","archived":false,"hash":"56d73a2bec6c9daad0104579ee1bdeeda9f4aa49","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/214/mbox/","series":[{"id":73,"url":"https://patchwork.libcamera.org/api/1.1/series/73/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=73","date":"2019-01-12T14:14:33","name":"test: media_device: Add link handling test","version":3,"mbox":"https://patchwork.libcamera.org/series/73/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/214/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/214/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD6060C6A\n\tfor ;\n\tSat, 12 Jan 2019 15:14:36 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id A2D8140003;\n\tSat, 12 Jan 2019 14:14:35 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 12 Jan 2019 15:14:35 +0100","Message-Id":"<20190112141436.1562-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190112141436.1562-1-jacopo@jmondi.org>","References":"<20190112141436.1562-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 2/3] test: media_device: Make\n\tMediaDeviceTest a MediaDevicePrintTest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 12 Jan 2019 14:14:36 -0000"},"content":"As a new class for test link handling will be added as a separate test,\nit makes no sense to have a generic \"MediaDeviceTest\" class. Rename it\nin \"MediaDevicePrintTest\", and make it run only printing test.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n ...e_test.cpp => media_device_print_test.cpp} | 31 +++++++++----------\n test/media_device/meson.build | 2 +-\n 2 files changed, 15 insertions(+), 18 deletions(-)\n rename test/media_device/{media_device_test.cpp => media_device_print_test.cpp} (79%)","diff":"diff --git a/test/media_device/media_device_test.cpp b/test/media_device/media_device_print_test.cpp\nsimilarity index 79%\nrename from test/media_device/media_device_test.cpp\nrename to test/media_device/media_device_print_test.cpp\nindex c482b2e..13af722 100644\n--- a/test/media_device/media_device_test.cpp\n+++ b/test/media_device/media_device_print_test.cpp\n@@ -1,10 +1,8 @@\n /* SPDX-License-Identifier: GPL-2.0-or-later */\n /*\n- * Copyright (C) 2018, Google Inc.\n+ * Copyright (C) 2018-2019, Google Inc.\n *\n- * media_device_test.cpp - Tests for the media device class.\n- *\n- * Test library for the media device class.\n+ * media_device_print_test.cpp - Print out media devices\n */\n #include \n \n@@ -20,16 +18,16 @@ using namespace libcamera;\n using namespace std;\n \n /*\n- * MediaDeviceTest object: runs a sequence of tests on all media\n- * devices found in the system.\n+ * MediaDevicePrintTest takes all media devices found in the system and print\n+ * them out to verify correctness.\n *\n * If no accessible media device is found, the test is skipped.\n */\n-class MediaDeviceTest : public Test\n+class MediaDevicePrintTest : public Test\n {\n public:\n-\tMediaDeviceTest() { }\n-\t~MediaDeviceTest() { }\n+\tMediaDevicePrintTest() { }\n+\t~MediaDevicePrintTest() { }\n \n protected:\n \tint init() { return 0; }\n@@ -44,7 +42,7 @@ private:\n \tvoid printNode(const MediaPad *pad, ostream &os);\n };\n \n-void MediaDeviceTest::printNode(const MediaPad *pad, ostream &os)\n+void MediaDevicePrintTest::printNode(const MediaPad *pad, ostream &os)\n {\n \tconst MediaEntity *entity = pad->entity();\n \n@@ -52,7 +50,7 @@ void MediaDeviceTest::printNode(const MediaPad *pad, ostream &os)\n \t << pad->index() << \"]\";\n }\n \n-void MediaDeviceTest::printLinkFlags(const MediaLink *link, ostream &os)\n+void MediaDevicePrintTest::printLinkFlags(const MediaLink *link, ostream &os)\n {\n \tunsigned int flags = link->flags();\n \n@@ -68,7 +66,7 @@ void MediaDeviceTest::printLinkFlags(const MediaLink *link, ostream &os)\n * For each entity in the media graph, printout links directed to its sinks\n * and source pads.\n */\n-void MediaDeviceTest::printMediaGraph(const MediaDevice &media, ostream &os)\n+void MediaDevicePrintTest::printMediaGraph(const MediaDevice &media, ostream &os)\n {\n \tos << \"\\n\" << media.driver() << \" - \" << media.devnode() << \"\\n\\n\";\n \n@@ -110,7 +108,7 @@ void MediaDeviceTest::printMediaGraph(const MediaDevice &media, ostream &os)\n }\n \n /* Test a single media device. */\n-int MediaDeviceTest::testMediaDevice(const string devnode)\n+int MediaDevicePrintTest::testMediaDevice(const string devnode)\n {\n \tMediaDevice dev(devnode);\n \tint ret;\n@@ -134,9 +132,8 @@ int MediaDeviceTest::testMediaDevice(const string devnode)\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Run tests in sequence. */\n+\t/* Print out the media graph. */\n \tprintMediaGraph(dev, cerr);\n-\t/* TODO: add more tests here. */\n \n \tdev.close();\n \n@@ -145,7 +142,7 @@ int MediaDeviceTest::testMediaDevice(const string devnode)\n \n /* Run tests on all media devices. */\n #define MAX_MEDIA_DEV 256\n-int MediaDeviceTest::run()\n+int MediaDevicePrintTest::run()\n {\n \tconst string devnode(\"/dev/media\");\n \tunsigned int i;\n@@ -171,4 +168,4 @@ int MediaDeviceTest::run()\n \treturn ret;\n }\n \n-TEST_REGISTER(MediaDeviceTest);\n+TEST_REGISTER(MediaDevicePrintTest);\ndiff --git a/test/media_device/meson.build b/test/media_device/meson.build\nindex 40f9ffa..e4bedb7 100644\n--- a/test/media_device/meson.build\n+++ b/test/media_device/meson.build\n@@ -1,5 +1,5 @@\n media_device_tests = [\n- ['media_device_test', 'media_device_test.cpp'],\n+ ['media_device_print_test', 'media_device_print_test.cpp'],\n ]\n \n foreach t : media_device_tests\n","prefixes":["libcamera-devel","v3","2/3"]}