{"id":21397,"url":"https://patchwork.libcamera.org/api/1.1/patches/21397/?format=json","web_url":"https://patchwork.libcamera.org/patch/21397/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240927134624.801004-5-mzamazal@redhat.com>","date":"2024-09-27T13:46:10","name":"[v8,04/18] libcamera: software_isp: Let IPASoftSimple inherit Module","commit_ref":"0cc74c492a89f639059292449d90b171876949c7","pull_url":null,"state":"accepted","archived":false,"hash":"1f94dd095867e0d340f4969251ad580576b6443f","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21397/mbox/","series":[{"id":4634,"url":"https://patchwork.libcamera.org/api/1.1/series/4634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4634","date":"2024-09-27T13:46:06","name":"Software ISP refactoring","version":8,"mbox":"https://patchwork.libcamera.org/series/4634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21397/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21397/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D704C32D4\n\tfor ;\n\tFri, 27 Sep 2024 13:46:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C74176351F;\n\tFri, 27 Sep 2024 15:46:51 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9087063510\n\tfor ;\n\tFri, 27 Sep 2024 15:46:47 +0200 (CEST)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-654--HLwhPcjNxuyghIm66gEsg-1;\n\tFri, 27 Sep 2024 09:46:43 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (unknown\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3D88F196E0AB; Fri, 27 Sep 2024 13:46:42 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.123])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 546631944E45; Fri, 27 Sep 2024 13:46:40 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QvizP+9Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1727444806;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=HhuZ75Fv0BSljhMklqICnG2unoMtXQeTfP6AlBK6LZI=;\n\tb=QvizP+9ZLYOkR0mjzuRbbLidocIhcuiiNCZ+l8NFoDk6WfNXwySnKaksh3uWsvkCJ8ijak\n\tawHJuSo6/uF7qk5FuBlX6s67Nwaz/T9vIfwtj7XLdpkCNT6l6TKfhI92owwe1eKvaPb9fN\n\t2XYivnIHDlfUggYs/sPcKOKdKopHeKo=","X-MC-Unique":"-HLwhPcjNxuyghIm66gEsg-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ,\n\tLaurent Pinchart ,\n\tDaniel Scally ,\n\tKieran Bingham ","Subject":"[PATCH v8 04/18] libcamera: software_isp: Let IPASoftSimple inherit\n\tModule","Date":"Fri, 27 Sep 2024 15:46:10 +0200","Message-ID":"<20240927134624.801004-5-mzamazal@redhat.com>","In-Reply-To":"<20240927134624.801004-1-mzamazal@redhat.com>","References":"<20240927134624.801004-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Module class is a base class for all IPA modules.\nIn addition, implement logPrefix() of the module for the softIPA.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nReviewed-by: Daniel Scally \nReviewed-by: Laurent Pinchart \n---\n src/ipa/simple/soft_simple.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b7746ce09..72321f443 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -30,6 +30,7 @@\n #include \"libipa/camera_sensor_helper.h\"\n \n #include \"black_level.h\"\n+#include \"module.h\"\n \n namespace libcamera {\n LOG_DEFINE_CATEGORY(IPASoft)\n@@ -54,7 +55,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n */\n static constexpr float kExposureSatisfactory = 0.2;\n \n-class IPASoftSimple : public ipa::soft::IPASoftInterface\n+class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n@@ -76,6 +77,9 @@ public:\n \n \tvoid processStats(const ControlList &sensorControls) override;\n \n+protected:\n+\tstd::string logPrefix() const override;\n+\n private:\n \tvoid updateExposure(double exposureMSV);\n \n@@ -421,6 +425,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)\n \tagain_ = std::clamp(again_, againMin_, againMax_);\n }\n \n+std::string IPASoftSimple::logPrefix() const\n+{\n+\treturn \"IPASoft\";\n+}\n+\n } /* namespace ipa::soft */\n \n /*\n","prefixes":["v8","04/18"]}