{"id":21377,"url":"https://patchwork.libcamera.org/api/1.1/patches/21377/?format=json","web_url":"https://patchwork.libcamera.org/patch/21377/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240926093623.94136-2-umang.jain@ideasonboard.com>","date":"2024-09-26T09:36:20","name":"[v8,1/4] libcamera: converter: Add interface for feature flags","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4fbb105a2700f364b803570974086418ee09571b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21377/mbox/","series":[{"id":4629,"url":"https://patchwork.libcamera.org/api/1.1/series/4629/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4629","date":"2024-09-26T09:36:19","name":"rkisp1: Plumb the DW100 dewarper as converter","version":8,"mbox":"https://patchwork.libcamera.org/series/4629/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21377/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21377/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 295B6C3257\n\tfor ;\n\tThu, 26 Sep 2024 09:36:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B32D46350E;\n\tThu, 26 Sep 2024 11:36:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A93E634FB\n\tfor ;\n\tThu, 26 Sep 2024 11:36:35 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40C67D80;\n\tThu, 26 Sep 2024 11:35:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e0clTj3/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727343307;\n\tbh=S99GqCK6+UJwt8YdATcB/WOR56/UU/5GwdyfW01ZR4o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e0clTj3/1ojM+uGZZqyKL1Sac9DTxgHZmy6LQuArRTtIY+JO6XzFIk/gVFzPcdj5b\n\tPEn8EWitlUrI2gNxE/I4zzVGpRaVlpWNoXkyBdByEFvk91O3sFRRXGpy/Hfn4R05OX\n\tiTg3bcaE00wz8wM2W6JliewvqPsrtm8tJwC/IxL0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ,\n\tStefan Klug ,\n\tUmang Jain ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v8 1/4] libcamera: converter: Add interface for feature flags","Date":"Thu, 26 Sep 2024 15:06:20 +0530","Message-ID":"<20240926093623.94136-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.45.0","In-Reply-To":"<20240926093623.94136-1-umang.jain@ideasonboard.com>","References":"<20240926093623.94136-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch intends to extend the converter interface to have feature\nflags, which enables each converter to expose the set of features\nit supports.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/converter.h | 14 +++++++++-\n src/libcamera/converter.cpp | 27 ++++++++++++++++++-\n .../converter/converter_v4l2_m2m.cpp | 4 +++\n 3 files changed, 43 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\nindex b51563d7..6623de4d 100644\n--- a/include/libcamera/internal/converter.h\n+++ b/include/libcamera/internal/converter.h\n@@ -17,6 +17,7 @@\n #include \n \n #include \n+#include \n #include \n \n #include \n@@ -32,7 +33,13 @@ struct StreamConfiguration;\n class Converter\n {\n public:\n-\tConverter(MediaDevice *media);\n+\tenum class Feature {\n+\t\tNone = 0,\n+\t};\n+\n+\tusing Features = Flags;\n+\n+\tConverter(MediaDevice *media, Features features = Feature::None);\n \tvirtual ~Converter();\n \n \tvirtual int loadConfiguration(const std::string &filename) = 0;\n@@ -61,6 +68,11 @@ public:\n \n \tconst std::string &deviceNode() const { return deviceNode_; }\n \n+\tFeatures features() const { return features_; }\n+\n+protected:\n+\tFeatures features_;\n+\n private:\n \tstd::string deviceNode_;\n };\ndiff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 8237998f..d7bb7273 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -34,14 +34,27 @@ LOG_DEFINE_CATEGORY(Converter)\n * parameters from the same input stream.\n */\n \n+/**\n+ * \\enum Converter::Feature\n+ * \\brief Specify the features supported by the converter\n+ * \\var Converter::Feature::None\n+ * \\brief No extra features supported by the converter\n+ */\n+\n+/**\n+ * \\typedef Converter::Features\n+ * \\brief A bitwise combination of features supported by the converter\n+ */\n+\n /**\n * \\brief Construct a Converter instance\n * \\param[in] media The media device implementing the converter\n+ * \\param[in] features Features flags representing supported features\n *\n * This searches for the entity implementing the data streaming function in the\n * media graph entities and use its device node as the converter device node.\n */\n-Converter::Converter(MediaDevice *media)\n+Converter::Converter(MediaDevice *media, Features features)\n {\n \tconst std::vector &entities = media->entities();\n \tauto it = std::find_if(entities.begin(), entities.end(),\n@@ -56,6 +69,7 @@ Converter::Converter(MediaDevice *media)\n \t}\n \n \tdeviceNode_ = (*it)->deviceNode();\n+\tfeatures_ = features;\n }\n \n Converter::~Converter()\n@@ -157,12 +171,23 @@ Converter::~Converter()\n * \\brief A signal emitted on each frame buffer completion of the output queue\n */\n \n+/**\n+ * \\var Converter::features_\n+ * \\brief Stores the features supported by the converter\n+ */\n+\n /**\n * \\fn Converter::deviceNode()\n * \\brief The converter device node attribute accessor\n * \\return The converter device node string\n */\n \n+/**\n+ * \\fn Converter::features()\n+ * \\brief Retrieve the features supported by the converter\n+ * \\return The converter Features flags\n+ */\n+\n /**\n * \\class ConverterFactoryBase\n * \\brief Base class for converter factories\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex e4f656da..4f3e8ce4 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -446,6 +446,10 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n \treturn 0;\n }\n \n+/*\n+ * \\todo: This should be extended to include Feature::Flag to denote\n+ * what each converter supports feature-wise.\n+ */\n static std::initializer_list compatibles = {\n \t\"mtk-mdp\",\n \t\"pxp\",\n","prefixes":["v8","1/4"]}