{"id":21343,"url":"https://patchwork.libcamera.org/api/1.1/patches/21343/?format=json","web_url":"https://patchwork.libcamera.org/patch/21343/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240924110353.2025397-2-chenghaoyang@google.com>","date":"2024-09-24T11:02:44","name":"[v7,1/3] libcamera: Add rectangle two-point constructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c5a5ec5fbc408d679101ac66223b39680cc10cae","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21343/mbox/","series":[{"id":4618,"url":"https://patchwork.libcamera.org/api/1.1/series/4618/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4618","date":"2024-09-24T11:02:43","name":"Add Face Detection Controls","version":7,"mbox":"https://patchwork.libcamera.org/series/4618/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21343/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21343/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC814C0F1B\n\tfor ;\n\tTue, 24 Sep 2024 11:04:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 158D263513;\n\tTue, 24 Sep 2024 13:04:05 +0200 (CEST)","from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com\n\t[IPv6:2607:f8b0:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E695063500\n\tfor ;\n\tTue, 24 Sep 2024 13:04:01 +0200 (CEST)","by mail-pg1-x52d.google.com with SMTP id\n\t41be03b00d2f7-7d4f85766f0so4412500a12.2\n\tfor ;\n\tTue, 24 Sep 2024 04:04:01 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71afc9833c3sm993326b3a.182.2024.09.24.04.03.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Sep 2024 04:03:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FahYZNLq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727175840; x=1727780640;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=tBhL4xEvsxdss/ASWIxhXN6eYcF3o/Wyd4aQEAOsBrg=;\n\tb=FahYZNLqt2rl4hJLp0x1jjUNeqSLPFsH2t5RbNwmwBRI+cc/c849W3RY8oej05U6W3\n\th0Hapo0gDSkgbvGWVke+evAdLjdwFZhtob5Ar8drZO24rvcenEfEuNOO4LpvM6SBcaoX\n\ts7MwnnSH/lOXu0y/PKkDe+eOQnXX1fp8uJgkI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727175840; x=1727780640;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=tBhL4xEvsxdss/ASWIxhXN6eYcF3o/Wyd4aQEAOsBrg=;\n\tb=BHIsgZfHhX2cWgwqlV8vE2y9WXNHQ/e5e1jyMHqadNBfEy0Y2A4E6+aWuls1/EQ8Yu\n\to5EKLS+9mYeWAFUjI3MjQ36L92U0A1Qi8WpDq18e6eKqbFcQ0IzZlKrCNS4q+X04vdqK\n\tGAtjOKJoUABeYDEcJA9foyPZ5rWWOQVmxuz5Mc4gVU1aNtmEqaabu6gmfZ1r2/M59eI7\n\tZzSebejlKNYhwJCkWcLvZxk0ZXX9y5zoNXL2X62/G4fOk8IPRvXaLgmcC7W2ExUtZGDq\n\tTNOzo5V4wmhuzepA+ah511rJrINHD1a/bUIZ2Nj8wxrj7hCt4jQ1r7m+bSFpoCeTrb0w\n\tpPvg==","X-Gm-Message-State":"AOJu0YzA93dP1TKs9ihh0RhypH76h4XD7fBE1RFXEr5HUel7vdY/PCYO\n\tfU/RwO5NaYB46vuMfOB6BTDXSrmn8BKX6jgymrMCh+IhMF8EdQ3qEBcbdyXUItTb+T6/LQxZ8fk\n\t=","X-Google-Smtp-Source":"AGHT+IG1M9lyMeWoMjzcxqNis2T6ntd6MqQMTJ80QPDeKDr5IqagisbDRoIp0jiWlXhj1ywg+ZnxyQ==","X-Received":"by 2002:a05:6a21:1193:b0:1d2:e1cc:649c with SMTP id\n\tadf61e73a8af0-1d30a91f295mr19977155637.15.1727175840127; \n\tTue, 24 Sep 2024 04:04:00 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Yudhistira Erlandinata ,\n\tHarvey Yang ,\n\tJacopo Mondi ","Subject":"[PATCH v7 1/3] libcamera: Add rectangle two-point constructor","Date":"Tue, 24 Sep 2024 11:02:44 +0000","Message-ID":"<20240924110353.2025397-2-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.792.g87dc391469-goog","In-Reply-To":"<20240924110353.2025397-1-chenghaoyang@google.com>","References":"<20240924110353.2025397-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd a Rectangle constructor that accepts two points:\ntopLeft and bottomRight.\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \nReviewed-by: Jacopo Mondi \n---\n include/libcamera/geometry.h | 7 +++++++\n src/libcamera/geometry.cpp | 7 +++++++\n test/geometry.cpp | 14 ++++++++++++++\n 3 files changed, 28 insertions(+)","diff":"diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 3e6f0f5d..5949d55c 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -262,6 +262,13 @@ public:\n \t{\n \t}\n \n+\tconstexpr Rectangle(const Point &point1, const Point &point2)\n+\t\t: Rectangle(std::min(point1.x, point2.x), std::max(point1.y, point2.y),\n+\t\t\t std::max(point1.x, point2.x) - std::min(point1.x, point2.x),\n+\t\t\t std::max(point1.y, point2.y) - std::min(point1.y, point2.y))\n+\t{\n+\t}\n+\n \tint x;\n \tint y;\n \tunsigned int width;\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 00015136..3c47dcdc 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -629,6 +629,13 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n * \\param[in] size The desired Rectangle size\n */\n \n+/**\n+ * \\fn Rectangle::Rectangle(const Point &point1, const Point &point2)\n+ * \\brief Construct a Rectangle with the two given points\n+ * \\param[in] point1 One corner point of the rectangle\n+ * \\param[in] point2 The diagonal corner point from \\a point1\n+ */\n+\n /**\n * \\var Rectangle::x\n * \\brief The horizontal coordinate of the rectangle's top-left corner\ndiff --git a/test/geometry.cpp b/test/geometry.cpp\nindex 64169206..3ed2cc23 100644\n--- a/test/geometry.cpp\n+++ b/test/geometry.cpp\n@@ -481,6 +481,20 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\tPoint topLeft(3, 3);\n+\t\tPoint bottomRight(30, 30);\n+\t\tPoint topRight(30, 3);\n+\t\tPoint bottomLeft(3, 30);\n+\t\tRectangle rect1(topLeft, bottomRight);\n+\t\tRectangle rect2(topRight, bottomLeft);\n+\t\tRectangle rect3(bottomRight, topLeft);\n+\t\tRectangle rect4(bottomLeft, topRight);\n+\n+\t\tif (rect1 != rect2 || rect1 != rect3 || rect1 != rect4) {\n+\t\t\tcout << \"Point-from-point construction failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n","prefixes":["v7","1/3"]}