{"id":21341,"url":"https://patchwork.libcamera.org/api/1.1/patches/21341/?format=json","web_url":"https://patchwork.libcamera.org/patch/21341/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240924090051.1617040-3-chenghaoyang@google.com>","date":"2024-09-24T08:26:11","name":"[v2,2/2] libcamera: Add gc08a3 camera sensor proprietary for ciri","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1ab467cbe49b6b18465897154f04ef434a061038","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21341/mbox/","series":[{"id":4617,"url":"https://patchwork.libcamera.org/api/1.1/series/4617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4617","date":"2024-09-24T08:26:09","name":"Add camera sensor properties for ciri","version":2,"mbox":"https://patchwork.libcamera.org/series/4617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21341/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21341/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27851C32D4\n\tfor ;\n\tTue, 24 Sep 2024 09:01:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B7BA63513;\n\tTue, 24 Sep 2024 11:01:04 +0200 (CEST)","from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com\n\t[IPv6:2607:f8b0:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6A4B63513\n\tfor ;\n\tTue, 24 Sep 2024 11:01:00 +0200 (CEST)","by mail-pl1-x62f.google.com with SMTP id\n\td9443c01a7336-206b9455460so40066585ad.0\n\tfor ;\n\tTue, 24 Sep 2024 02:01:00 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20af185853dsm6803885ad.265.2024.09.24.02.00.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Sep 2024 02:00:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"COkv8pOY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727168459; x=1727773259;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+NCC7SL2eB+/9TOyBTPsQ+hL3qvY0sKdb0xgfgyUC3E=;\n\tb=COkv8pOYa8O1fFmsNeKrzs3N+7myAjn+cFel1EizPdaqzCwzQIn2dYF6hviFq//QQv\n\tsPU2Vo8WgHpOKTIR/6sH4blsAtdzzsmy85GrMiO5Xqm1zWTJry0zVa3VVyCsPNz4xslB\n\tYvMI4Cv6FORZewlJ4s7EspOOb9H4clRWH6D6U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727168459; x=1727773259;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=+NCC7SL2eB+/9TOyBTPsQ+hL3qvY0sKdb0xgfgyUC3E=;\n\tb=txzUmNEPlaU4e2KJwlJrFdB2s5iG/OtXLuWLKlFVIytOx9BUSf2QZiKIESsm8uyIm8\n\tznQ1DdIa+6oy0Q3acLZ+67MQ5O7R514m1Wiq4YBSW6cpEgtU1jxflxqj9PlHdVljpbPv\n\t2UOQjxvtjnbXZvbclrUf2weLh8P/DjHudgQSeWCHYW6R2QsMvOGEFod+f8H+zO+bcKrl\n\teGsuDJUEfCNr/CZydcWliXWZ+1wGUpwUDAGXGnk+AOe7tV2A12WRKJM3UBzEdZv7hzPf\n\tjvZOYaVPXwfMnkEG8HiAO6ZO35JbMtuKUN4B0qMMz99d3bZa9qEjIP/CZDzS/PmPq3qc\n\txtlA==","X-Gm-Message-State":"AOJu0YybI8QyXAKndavr++Z+mjHvkEfTaqs6gsqbshc/CVQuL45OpogP\n\tJh72pJOHQaYlvcMpPfabnVq82p5TvEjI5kOZW5Q8n57LidBe/lfB5TNDXkX3m8WH/UPQHdXn6PU\n\t=","X-Google-Smtp-Source":"AGHT+IF0kGs1qL4BPHPVSnRV3JOIPvwroAd9a8XJYE86mpJ8aNGozfdBFEJe6bQspVpe4uP0jAt5XQ==","X-Received":"by 2002:a17:902:e74b:b0:205:7b04:dde1 with SMTP id\n\td9443c01a7336-20aed111f57mr43291855ad.20.1727168458889; \n\tTue, 24 Sep 2024 02:00:58 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ,\n\tHarvey Yang ","Subject":"[PATCH v2 2/2] libcamera: Add gc08a3 camera sensor proprietary for\n\tciri","Date":"Tue, 24 Sep 2024 08:26:11 +0000","Message-ID":"<20240924090051.1617040-3-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.792.g87dc391469-goog","In-Reply-To":"<20240924090051.1617040-1-chenghaoyang@google.com>","References":"<20240924090051.1617040-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"gc08a3 is the second sensor used by ciri.\n\nSigned-off-by: Han-Lin Chen \nCo-developed-by: Xing Gu \nCo-developed-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 17 +++++++++++++++++\n .../sensor/camera_sensor_properties.cpp | 7 +++++++\n 2 files changed, 24 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex cd7d12d6..afa177fe 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -536,6 +536,23 @@ private:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n \n+class CameraSensorHelperGc08a3 : public CameraSensorHelper\n+{\n+public:\n+\tuint32_t gainCode(double gain) const override\n+\t{\n+\t\tuint32_t aeGain = std::clamp((uint32_t)gain, kAeBaseGain_, kStep_ * kAeBaseGain_);\n+\t\treturn aeGain * 0x400 / kAeBaseGain_;\n+\t}\n+\n+\t// `double gain(uint32_t gainCode)` will not be used.\n+\n+private:\n+\tstatic constexpr uint32_t kStep_ = 16;\n+\tstatic constexpr uint32_t kAeBaseGain_ = 1024;\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n+\n class CameraSensorHelperImx219 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 3e1bd85e..c76c8088 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -77,6 +77,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"gc08a3\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 2 },\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n","prefixes":["v2","2/2"]}