{"id":21277,"url":"https://patchwork.libcamera.org/api/1.1/patches/21277/?format=json","web_url":"https://patchwork.libcamera.org/patch/21277/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240915235044.2188179-3-paul.elder@ideasonboard.com>","date":"2024-09-15T23:50:44","name":"[v3,2/2] apps: cam: Print control array sizes","commit_ref":"f2088eb91fd6477b152233b9031cb115ca1ae824","pull_url":null,"state":"accepted","archived":false,"hash":"620e347c72ec86cf099f0e2cec373a8f3d7bb8a7","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21277/mbox/","series":[{"id":4599,"url":"https://patchwork.libcamera.org/api/1.1/series/4599/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4599","date":"2024-09-15T23:50:42","name":"Add array information to ControlId","version":3,"mbox":"https://patchwork.libcamera.org/series/4599/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21277/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21277/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B7C6C3261\n\tfor ;\n\tSun, 15 Sep 2024 23:51:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0935D634FB;\n\tMon, 16 Sep 2024 01:50:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B99F634FB\n\tfor ;\n\tMon, 16 Sep 2024 01:50:52 +0200 (CEST)","from pyrite.hamster-moth.ts.net (unknown\n\t[IPv6:2001:4bc9:a45:b0af:31d1:7a87:7f90:977b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69E8AD8B;\n\tMon, 16 Sep 2024 01:49:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CTLKn/Il\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726444171;\n\tbh=1Iqtbgui5vKHaW0ji4EST6Xx1rOjwlG7X4MePoU0kmk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CTLKn/IlqAnS/BrMwwdKUz32bVGKgM+ZI8XD/s4nV7SQJG3pzkhqiSGWckQr8c0xf\n\twD1tTOBmJywi8qcWj0mcvy0Akuz5Ooqo2UszvaynU/FuSFK9dHpBzL/4YCXV+8nNmm\n\tQW2APBUKEUx1A2LHkyM5213QVC2+ajNJpJuK0iUQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tKieran Bingham ,\n\tstefan.klug@ideasonboard.com,\n\tLaurent Pinchart ","Subject":"[PATCH v3 2/2] apps: cam: Print control array sizes","Date":"Mon, 16 Sep 2024 01:50:44 +0200","Message-Id":"<20240915235044.2188179-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20240915235044.2188179-1-paul.elder@ideasonboard.com>","References":"<20240915235044.2188179-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that controls can be queried for array information, print it in\n--list-controls when applicable.\n\nExample output (with dummy controls added to vimc):\n\n$ cam -c 1 --list-controls\nUsing camera platform/vimc.0 Sensor B as cam0\nControl: ColourGains: [1.000000..4.000000]\n Size: 2\nControl: Brightness: [-1.000000..1.000000]\nControl: AfWindows: [(0, 0)/1x1..(0, 0)/100x100]\n Size: n\nControl: Contrast: [0.000000..2.000000]\nControl: Saturation: [0.000000..2.000000]\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v3:\n- fix line wrap\n- add example to commit message\n\nNo change in v2\n---\n src/apps/cam/camera_session.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex fc0923801..d24ecbb3a 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -176,6 +176,17 @@ void CameraSession::listControls() const\n \t\t\t\tstd::cout << \" (\" << val << \")\" << std::endl;\n \t\t\t}\n \t\t}\n+\n+\t\tif (id->isArray()) {\n+\t\t\tstd::size_t size = id->size();\n+\n+\t\t\tstd::cout << \" Size: \";\n+\t\t\tif (size == std::numeric_limits::max())\n+\t\t\t\tstd::cout << \"n\";\n+\t\t\telse\n+\t\t\t\tstd::cout << std::to_string(size);\n+\t\t\tstd::cout << std::endl;\n+\t\t}\n \t}\n }\n \n","prefixes":["v3","2/2"]}