{"id":2125,"url":"https://patchwork.libcamera.org/api/1.1/patches/2125/?format=json","web_url":"https://patchwork.libcamera.org/patch/2125/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191007085842.7608-4-jacopo@jmondi.org>","date":"2019-10-07T08:58:40","name":"[libcamera-devel,v4,3/5] ipa: meson: Give IPAs access to internal libcamera APIs","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"864a7292aa79a273595e6c4bafc7db6f76f64a45","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2125/mbox/","series":[{"id":525,"url":"https://patchwork.libcamera.org/api/1.1/series/525/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=525","date":"2019-10-07T08:58:37","name":"test: Add IPA interface test support","version":4,"mbox":"https://patchwork.libcamera.org/series/525/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2125/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2125/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C76761565\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  7 Oct 2019 10:57:03 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id DD938240005\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  7 Oct 2019 08:57:02 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  7 Oct 2019 10:58:40 +0200","Message-Id":"<20191007085842.7608-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191007085842.7608-1-jacopo@jmondi.org>","References":"<20191007085842.7608-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 3/5] ipa: meson: Give IPAs access to\n\tinternal libcamera APIs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 07 Oct 2019 08:57:03 -0000"},"content":"Open source IPA implementations can benefit from usage of libcamera\ninternal APIs. Allow this by compiling against the internal headers and\nlinking against libcamera.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/meson.build | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex b5bcd7b2c3db..ac16e1da6126 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -5,10 +5,16 @@ ipa_vimc_sources = [\n \n ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n \n+ipa_includes = [\n+    libcamera_includes,\n+    libcamera_internal_includes,\n+]\n+\n foreach t : ipa_vimc_sources\n     ipa = shared_module(t[0], 'ipa_vimc.cpp',\n                         name_prefix : '',\n-                        include_directories : libcamera_includes,\n+                        include_directories : ipa_includes,\n+                        dependencies : libcamera_dep,\n                         install : true,\n                         install_dir : ipa_install_dir,\n                         cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n","prefixes":["libcamera-devel","v4","3/5"]}