{"id":21242,"url":"https://patchwork.libcamera.org/api/1.1/patches/21242/?format=json","web_url":"https://patchwork.libcamera.org/patch/21242/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","date":"2024-09-11T21:18:16","name":"[v2,4/4] libcamera: pipeline: simple: Use MediaLink string helper","commit_ref":"66c9b157e95b108b38f1ac2f13b827fafef74602","pull_url":null,"state":"accepted","archived":false,"hash":"d3d3eea4c73fe6f32464a1b31e0202af22bc267c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21242/mbox/","series":[{"id":4582,"url":"https://patchwork.libcamera.org/api/1.1/series/4582/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4582","date":"2024-09-11T21:18:12","name":"MediaLink: Provide a string representation","version":2,"mbox":"https://patchwork.libcamera.org/series/4582/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21242/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21242/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B37BC324C\n\tfor ;\n\tWed, 11 Sep 2024 21:18:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE7C863504;\n\tWed, 11 Sep 2024 23:18:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82161618FB\n\tfor ;\n\tWed, 11 Sep 2024 23:18:28 +0200 (CEST)","from charm.tail69b4.ts.net (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE02E83D;\n\tWed, 11 Sep 2024 23:17:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rf7wvaqq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726089430;\n\tbh=8nXkTcGf9vdwvW3F6/FAMBsw3uFOD7oG4nZ2jAC0Ps0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rf7wvaqqEAMQnlIgxgqP7SClAd+DwEwl2d5yo3tORyxaBO6xL/uugvS/i5owU8GCy\n\tyWs1o0+zr3kygtnq9XX3ZLr+uf31C/ID/A7FuonwloLunjBq5XyGp7NWeIzIHV1F80\n\tP2MQerjCYuJoCSW+mqt8bqfmso28z/2JYXFSPB+U=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 4/4] libcamera: pipeline: simple: Use MediaLink string\n\thelper","Date":"Wed, 11 Sep 2024 23:18:16 +0200","Message-ID":"<20240911211816.73763-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.46.0","In-Reply-To":"<20240911211816.73763-1-kieran.bingham@ideasonboard.com>","References":"<20240911211816.73763-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace the open-coded implementation of a link representation\nwith the operator<< overload string representation to simplify\nthe code and unify appearance of reporting MediaLinks.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 1e7ec7d97255..2d205e9925ef 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n \t\t}\n \n \t\tLOG(SimplePipeline, Debug)\n-\t\t\t<< \"Link '\" << source->entity()->name()\n-\t\t\t<< \"':\" << source->index()\n-\t\t\t<< \" -> '\" << sink->entity()->name()\n-\t\t\t<< \"':\" << sink->index()\n-\t\t\t<< \" configured with format \" << *format;\n+\t\t\t<< \"Link \" << *link << \": configured with format \"\n+\t\t\t<< *format;\n \t}\n \n \treturn 0;\n","prefixes":["v2","4/4"]}