{"id":21213,"url":"https://patchwork.libcamera.org/api/1.1/patches/21213/?format=json","web_url":"https://patchwork.libcamera.org/patch/21213/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240910044834.2477701-8-chenghaoyang@google.com>","date":"2024-09-10T04:40:20","name":"[v12,7/7] libcamera: software_isp: Refactor SoftwareIsp to use DmaBufAllocator::exportBuffers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5f98528d63df8d5fec95e0c9da3bdff582bbd04e","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21213/mbox/","series":[{"id":4572,"url":"https://patchwork.libcamera.org/api/1.1/series/4572/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4572","date":"2024-09-10T04:40:13","name":"Add VirtualPipelineHandler","version":12,"mbox":"https://patchwork.libcamera.org/series/4572/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21213/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21213/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C9F3C3259\n\tfor ;\n\tTue, 10 Sep 2024 04:49:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86FB663506;\n\tTue, 10 Sep 2024 06:49:00 +0200 (CEST)","from mail-pf1-x429.google.com (mail-pf1-x429.google.com\n\t[IPv6:2607:f8b0:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A83AB63504\n\tfor ;\n\tTue, 10 Sep 2024 06:48:53 +0200 (CEST)","by mail-pf1-x429.google.com with SMTP id\n\td2e1a72fcca58-718d985b6bbso3322523b3a.2\n\tfor ;\n\tMon, 09 Sep 2024 21:48:53 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71909092522sm530734b3a.111.2024.09.09.21.48.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Sep 2024 21:48:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"JEfP4meY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725943732; x=1726548532;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Nd5Nqz3r9Z4samEGwXO+wdTcH/8P3Q2sO625ziMx2LY=;\n\tb=JEfP4meYK5ZWnV3c7xjdkrnliEJHM1xIz5OhkaSsWDpOD0eT/PcWymR/KvLCMMCGU+\n\tx05N1F3III//95V1HPoA+ZedLkb+CBFVVoiwSmkA0y4Zf5FspbfozVMIf3dap9MeHI/y\n\tlf+T6LXrGq3/GK6oU3uWzDwMQtrgjZGEtbqac=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725943732; x=1726548532;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Nd5Nqz3r9Z4samEGwXO+wdTcH/8P3Q2sO625ziMx2LY=;\n\tb=Y9VQygKIxw9Uda8XwSvorA35ei2Ov5o3OIhQ/7u3+oH2SyFTF2WjhwOdkFtKmsyIy2\n\tgL+iLPvDdJ990JIo107z0lLfuU9TkslSXSR2x3NsD014mNc9QhDklN8KZuyZ0ohWXmgm\n\tamoo+KuYs+KOXW1Kzpu1MVDj+1oy2y+ESKlCIzpwj0VC+SVAJE+jD8rO3Pg4E0m29dIq\n\tRb24TWHfxZdrUG0aFYpvWY4PLhgxdMrULt04p2g720DfcU9VlAEIuaUQdrAClnQbL7DC\n\taT53D1wWRSrzRoZd+hyLRZm6ql62GGF/2t/qpnCMTbOEAXk/xKNuc8HJNJ6U7aeB6/bi\n\t68jg==","X-Gm-Message-State":"AOJu0Yy+X7yPgLU6NctaAJHOWSKzhlSKS9WJSQoWaCZyt002HklSure0\n\tDFTXvrsen899Kflav4TG/xjgHDp6Eub4F0294Sf9kO9O6RICi5C4YaBam3534kjR9Zq9pG7cxRE\n\t=","X-Google-Smtp-Source":"AGHT+IH7VTMz3yJfR6awFkIWo4j6JUGLC67x0aMNNuoRjzBrg4ORVvhtSq4PKx/pUp8Uk/jGfAsb8w==","X-Received":"by 2002:a05:6a00:9492:b0:717:9483:5887 with SMTP id\n\td2e1a72fcca58-718d5e18c86mr14069916b3a.8.1725943731564; \n\tMon, 09 Sep 2024 21:48:51 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHarvey Yang ,\n\tMilan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v12 7/7] libcamera: software_isp: Refactor SoftwareIsp to use\n\tDmaBufAllocator::exportBuffers","Date":"Tue, 10 Sep 2024 04:40:20 +0000","Message-ID":"<20240910044834.2477701-8-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.598.g6f2099f65c-goog","In-Reply-To":"<20240910044834.2477701-1-chenghaoyang@google.com>","References":"<20240910044834.2477701-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As the helper function DmaBufAllocator::exportBuffers is added, we can\navoid some code duplication in SoftwareIsp as well.\n\nSigned-off-by: Harvey Yang \nReviewed-by: Milan Zamazal \nReviewed-by: Kieran Bingham \n---\n src/libcamera/software_isp/software_isp.cpp | 20 +-------------------\n 1 file changed, 1 insertion(+), 19 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 1140372c..3455f13a 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -255,25 +255,7 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n \tif (stream == nullptr)\n \t\treturn -EINVAL;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst std::string name = \"frame-\" + std::to_string(i);\n-\t\tconst size_t frameSize = debayer_->frameSize();\n-\n-\t\tFrameBuffer::Plane outPlane;\n-\t\toutPlane.fd = SharedFD(dmaHeap_.alloc(name.c_str(), frameSize));\n-\t\tif (!outPlane.fd.isValid()) {\n-\t\t\tLOG(SoftwareIsp, Error)\n-\t\t\t\t<< \"failed to allocate a dma_buf\";\n-\t\t\treturn -ENOMEM;\n-\t\t}\n-\t\toutPlane.offset = 0;\n-\t\toutPlane.length = frameSize;\n-\n-\t\tstd::vector planes{ outPlane };\n-\t\tbuffers->emplace_back(std::make_unique(std::move(planes)));\n-\t}\n-\n-\treturn count;\n+\treturn dmaHeap_.exportBuffers(count, { debayer_->frameSize() }, buffers);\n }\n \n /**\n","prefixes":["v12","7/7"]}