{"id":21194,"url":"https://patchwork.libcamera.org/api/1.1/patches/21194/?format=json","web_url":"https://patchwork.libcamera.org/patch/21194/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240907143110.2210711-3-chenghaoyang@google.com>","date":"2024-09-07T14:28:27","name":"[v11,2/7] libcamera: Remove PipelineHandler Fatal check of non-empty MediaDevices","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"41a946d8020fdd8433230175f39bba0b6d992b1c","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21194/mbox/","series":[{"id":4567,"url":"https://patchwork.libcamera.org/api/1.1/series/4567/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4567","date":"2024-09-07T14:28:25","name":"Add VirtualPipelineHandler","version":11,"mbox":"https://patchwork.libcamera.org/series/4567/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21194/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21194/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 102F3C324C\n\tfor ;\n\tSat, 7 Sep 2024 14:31:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 179C563500;\n\tSat, 7 Sep 2024 16:31:25 +0200 (CEST)","from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com\n\t[IPv6:2607:f8b0:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B58F634F8\n\tfor ;\n\tSat, 7 Sep 2024 16:31:21 +0200 (CEST)","by mail-pl1-x62d.google.com with SMTP id\n\td9443c01a7336-206aee4073cso29906045ad.1\n\tfor ;\n\tSat, 07 Sep 2024 07:31:20 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-20710e33974sm9208935ad.104.2024.09.07.07.31.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 07 Sep 2024 07:31:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"BY2826Vm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725719479; x=1726324279;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TSaImx5SqvHvHcxkD0MKMd1PCjbqNKbkJmxxCDje1YU=;\n\tb=BY2826VmRUlbra7N3EeIDmc0ItegsO5PLHmnfNoReBXybON+CyW6ZHepKmRzZqo9s+\n\t6JEubRADw0w+1PFhHoZ1iMkN5lBH4W3DQbn7jK5Hk+trqR43kHx7XCqPvBADUQs6iKYB\n\trwWQTSjXYfrKk/ke1y6Zksvf2v/QqOfRSttKg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725719479; x=1726324279;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TSaImx5SqvHvHcxkD0MKMd1PCjbqNKbkJmxxCDje1YU=;\n\tb=cc1EBtRtPCNJpZVO8qKNbsuQLB2j+Jii+z2KGpTBKxWR6GnqU8Wr0W5l3IGD7ddk6/\n\tmys4TLRFysToF8WUWH0nw9qnIoW5PEIBK2/YcEKD60SdG/CBgHrf9MH7QRMnIXXFCjLN\n\tMGQlvMgIdLmd2+b07gpp2h4AFixyGcAXExm9wHDxPhk3YBtMsKYoc3p6oDUom3DxCGiW\n\tN3yjySPSvRRE7UFCHKJiYUQSg2Y2UntlT6P2/ByRKUln/RCNLlRtaigpzelaVj2IJKEu\n\t0N+2j8sPNj4OUCqeRrIswvVKfdviXyNACAyCmv+Rlf0Uy5OjYKcIYmWwg3UwtviwOwln\n\tSGTQ==","X-Gm-Message-State":"AOJu0YwFWb+7emeY0a8GJUDrDgUIas6m4jAxqKaL/lczikXd/cZCUbWy\n\t1BglsQyXdjTbVJnyewCCPgFBrXrNZQEvV03K1nm45Remvk6qeRk/8xioiEtiqKJPYiW9oqxrXvk\n\t=","X-Google-Smtp-Source":"AGHT+IF3uenv51M0VgfyL75oqyePqqnwaZpZhmw4KETWNkMf8046r30qnUu2O/4mv2DcHLb1cnnAlg==","X-Received":"by 2002:a17:903:2303:b0:206:c12d:abad with SMTP id\n\td9443c01a7336-206f05523e9mr98570765ad.34.1725719479233; \n\tSat, 07 Sep 2024 07:31:19 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHarvey Yang ,\n\tLaurent Pinchart ","Subject":"[PATCH v11 2/7] libcamera: Remove PipelineHandler Fatal check of\n\tnon-empty MediaDevices","Date":"Sat, 7 Sep 2024 14:28:27 +0000","Message-ID":"<20240907143110.2210711-3-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.469.g59c65b2a67-goog","In-Reply-To":"<20240907143110.2210711-1-chenghaoyang@google.com>","References":"<20240907143110.2210711-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Fatal check of having at least one MediaDevice was to prevent\npipeline handler implementations searching and owning media devices with\ncustom conventions, instead of using the base function\n|acquireMediaDevice|. It also has the assumption that there's at least\none media device to make a camera work.\n\nNow that the assumption will be broken by the virtual pipeline handler\nadded in the following patches, and developers should be aware of the\navailable functions in the base class to handle media devices, the Fatal\ncheck is no longer needed.\n\nSigned-off-by: Harvey Yang \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline_handler.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e5940469..89a513e4 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -637,9 +637,14 @@ void PipelineHandler::registerCamera(std::shared_ptr camera)\n {\n \tcameras_.push_back(camera);\n \n-\tif (mediaDevices_.empty())\n-\t\tLOG(Pipeline, Fatal)\n-\t\t\t<< \"Registering camera with no media devices!\";\n+\tif (mediaDevices_.empty()) {\n+\t\t/*\n+\t\t * For virtual devices with no MediaDevice, there are no system\n+\t\t * devices to register.\n+\t\t */\n+\t\tmanager_->_d()->addCamera(std::move(camera));\n+\t\treturn;\n+\t}\n \n \t/*\n \t * Walk the entity list and map the devnums of all capture video nodes\n","prefixes":["v11","2/7"]}