{"id":2119,"url":"https://patchwork.libcamera.org/api/1.1/patches/2119/?format=json","web_url":"https://patchwork.libcamera.org/patch/2119/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191006200852.11775-4-jacopo@jmondi.org>","date":"2019-10-06T20:08:50","name":"[libcamera-devel,v3,3/5] ipa: meson: Allow IPAs to include internal headers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"864a7292aa79a273595e6c4bafc7db6f76f64a45","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2119/mbox/","series":[{"id":524,"url":"https://patchwork.libcamera.org/api/1.1/series/524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=524","date":"2019-10-06T20:08:47","name":"test: Add IPA interface test support","version":3,"mbox":"https://patchwork.libcamera.org/series/524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2119/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2119/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B724561968\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  6 Oct 2019 22:07:13 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 807F8C0003\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  6 Oct 2019 20:07:13 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Sun,  6 Oct 2019 22:08:50 +0200","Message-Id":"<20191006200852.11775-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191006200852.11775-1-jacopo@jmondi.org>","References":"<20191006200852.11775-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/5] ipa: meson: Allow IPAs to include\n\tinternal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 06 Oct 2019 20:07:14 -0000"},"content":"Extend the list of inclusion paths for the IPA modules in src/ipa/ to\ninclude internal libcamera headers.\n\nOnly Open Source IPA implementations will live in src/ipa/ and they link\nagainst libcamera, so they should be able to include internal headers as\nwell as public ones.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/meson.build | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex b5bcd7b2c3db..ac16e1da6126 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -5,10 +5,16 @@ ipa_vimc_sources = [\n \n ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n \n+ipa_includes = [\n+    libcamera_includes,\n+    libcamera_internal_includes,\n+]\n+\n foreach t : ipa_vimc_sources\n     ipa = shared_module(t[0], 'ipa_vimc.cpp',\n                         name_prefix : '',\n-                        include_directories : libcamera_includes,\n+                        include_directories : ipa_includes,\n+                        dependencies : libcamera_dep,\n                         install : true,\n                         install_dir : ipa_install_dir,\n                         cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n","prefixes":["libcamera-devel","v3","3/5"]}