{"id":21175,"url":"https://patchwork.libcamera.org/api/1.1/patches/21175/?format=json","web_url":"https://patchwork.libcamera.org/patch/21175/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240906120927.4071508-3-mzamazal@redhat.com>","date":"2024-09-06T12:09:11","name":"[v6,02/18] libcamera: software_isp: Move BlackLevel to libcamera::ipa::soft","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"29ac88f49c9b51c01da757fcad51d9da3db51e2f","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21175/mbox/","series":[{"id":4566,"url":"https://patchwork.libcamera.org/api/1.1/series/4566/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4566","date":"2024-09-06T12:09:09","name":"Software ISP refactoring","version":6,"mbox":"https://patchwork.libcamera.org/series/4566/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21175/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21175/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 767DCC324C\n\tfor ;\n\tFri, 6 Sep 2024 12:10:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D524D634F4;\n\tFri, 6 Sep 2024 14:10:03 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DA63634E3\n\tfor ;\n\tFri, 6 Sep 2024 14:09:57 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-691-COK4TYWZOYiOw4yAIQIzVA-1;\n\tFri, 06 Sep 2024 08:09:53 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id DADCB1953956; Fri, 6 Sep 2024 12:09:51 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.65])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E072B1956086; Fri, 6 Sep 2024 12:09:49 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Y6cNtbts\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725624596;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=SxcxrWdqckPYJJM31vXC2zzG/WyUmEsjDhhR7dm2j24=;\n\tb=Y6cNtbtsgYRtcXEUiDTBWKeHzcXfRoMlWXHMXCx/v8aNKyAtwmO8DfIFUWLWx229I7C44Q\n\t53PWDYnJu2YkZXMHSrUYDhES+cuWKqNeS9qN3yf4RM8cBqdfICxFKTq+7RE6yO11IcGIhk\n\tp7E1WnL0lK/UeMYXczWWvbF3NM1gbMI=","X-MC-Unique":"COK4TYWZOYiOw4yAIQIzVA-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ,\n\tLaurent Pinchart ,\n\tDaniel Scally ","Subject":"[PATCH v6 02/18] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","Date":"Fri, 6 Sep 2024 14:09:11 +0200","Message-ID":"<20240906120927.4071508-3-mzamazal@redhat.com>","In-Reply-To":"<20240906120927.4071508-1-mzamazal@redhat.com>","References":"<20240906120927.4071508-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"IPA modules use custom namespaces for all their internal components to\navoid namespace clashes. The simple IPA module for the software ISP uses\nlibcamera::ipa::soft for this purpose. It however defines an internal\nclass named BlackLevel in the root of the libcamera namespace, making it\nprone to clashes. Move it to the ipa::soft namespace along with the rest\nof the code.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Daniel Scally \n---\n src/ipa/simple/black_level.cpp | 5 +++++\n src/ipa/simple/black_level.h | 4 ++++\n 2 files changed, 9 insertions(+)","diff":"diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\nindex cc490eb5..37e0109c 100644\n--- a/src/ipa/simple/black_level.cpp\n+++ b/src/ipa/simple/black_level.cpp\n@@ -15,6 +15,8 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftBL)\n \n+namespace ipa::soft {\n+\n /**\n * \\class BlackLevel\n * \\brief Object providing black point level for software ISP\n@@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)\n \t\t}\n \t};\n }\n+\n+} /* namespace ipa::soft */\n+\n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\nindex 5e032f9f..a04230c9 100644\n--- a/src/ipa/simple/black_level.h\n+++ b/src/ipa/simple/black_level.h\n@@ -14,6 +14,8 @@\n \n namespace libcamera {\n \n+namespace ipa::soft {\n+\n class BlackLevel\n {\n public:\n@@ -26,4 +28,6 @@ private:\n \tbool blackLevelSet_;\n };\n \n+} /* namespace ipa::soft */\n+\n } /* namespace libcamera */\n","prefixes":["v6","02/18"]}