{"id":21148,"url":"https://patchwork.libcamera.org/api/1.1/patches/21148/?format=json","web_url":"https://patchwork.libcamera.org/patch/21148/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240902154212.1281257-19-mzamazal@redhat.com>","date":"2024-09-02T15:42:11","name":"[v3,18/18] libcamera: includes: Formatting improvements","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b6436ec6c16b31fc6756b12b78ff82e15f49a308","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21148/mbox/","series":[{"id":4556,"url":"https://patchwork.libcamera.org/api/1.1/series/4556/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4556","date":"2024-09-02T15:41:53","name":"Remove unused includes","version":3,"mbox":"https://patchwork.libcamera.org/series/4556/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21148/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21148/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3333EBF415\n\tfor ;\n\tMon, 2 Sep 2024 15:43:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1D34634F9;\n\tMon, 2 Sep 2024 17:43:10 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB3DB634F1\n\tfor ;\n\tMon, 2 Sep 2024 17:43:08 +0200 (CEST)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-265-hsMNwm_DMnq7dBlRP8wW_g-1;\n\tMon, 02 Sep 2024 11:43:04 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 179821955D53; Mon, 2 Sep 2024 15:43:04 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D82071955DD8; Mon, 2 Sep 2024 15:43:02 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ZzMPdfFE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291787;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=OKBLdLSkubi9KXFLt2nsRea/mNFciv/BE9jMsEtAaRE=;\n\tb=ZzMPdfFETSPxcy460bStohW8CdOaI2GdwIHdr8VVPPkuODmqL/iUpO3V6u+6l3dnnO1twn\n\tQc12U9Yddx+EnUSSam541KVFnoDqhQv/gzld0ra2OnAvdecat+4E0mzdXF8bJdOupgFjMF\n\tf02ZwS7461TQ4jy0IX9Kq7M77V6yoPE=","X-MC-Unique":"hsMNwm_DMnq7dBlRP8wW_g-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 18/18] libcamera: includes: Formatting improvements","Date":"Mon, 2 Sep 2024 17:42:11 +0200","Message-ID":"<20240902154212.1281257-19-mzamazal@redhat.com>","In-Reply-To":"<20240902154212.1281257-1-mzamazal@redhat.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The LSP autoformatter doesn't like some of the current formatting, let's\nmake it happier. Note that not all of its suggestions were accepted\nbecause readability is preferred and adjusting .clang-format may not be\neasy or possible.\n\nSigned-off-by: Milan Zamazal \n---\n include/libcamera/base/utils.h | 2 +-\n include/libcamera/internal/ipa_data_serializer.h | 7 ++++---\n 2 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 98c683a7..a9b27d0f 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -12,8 +12,8 @@\n #include \n #include \n #include \n-#include \n #include \n+#include \n #include \n #include \n #include \ndiff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 13470a89..66d9a19f 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -18,6 +18,7 @@\n #include \n #include \n #include \n+\n #include \n \n #include \"libcamera/internal/control_serializer.h\"\n@@ -161,7 +162,7 @@ public:\n \t\tstd::vector::const_iterator fdIter = fdsBegin;\n \t\tfor (uint32_t i = 0; i < vecLen; i++) {\n \t\t\tuint32_t sizeofData = readPOD(dataIter, 0, dataEnd);\n-\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n+\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n \t\t\tdataIter += 8;\n \n \t\t\tret[i] = IPADataSerializer::deserialize(dataIter,\n@@ -268,7 +269,7 @@ public:\n \t\tstd::vector::const_iterator fdIter = fdsBegin;\n \t\tfor (uint32_t i = 0; i < mapLen; i++) {\n \t\t\tuint32_t sizeofData = readPOD(dataIter, 0, dataEnd);\n-\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n+\t\t\tuint32_t sizeofFds = readPOD(dataIter, 4, dataEnd);\n \t\t\tdataIter += 8;\n \n \t\t\tK key = IPADataSerializer::deserialize(dataIter,\n@@ -280,7 +281,7 @@ public:\n \t\t\tdataIter += sizeofData;\n \t\t\tfdIter += sizeofFds;\n \t\t\tsizeofData = readPOD(dataIter, 0, dataEnd);\n-\t\t\tsizeofFds = readPOD(dataIter, 4, dataEnd);\n+\t\t\tsizeofFds = readPOD(dataIter, 4, dataEnd);\n \t\t\tdataIter += 8;\n \n \t\t\tconst V value = IPADataSerializer::deserialize(dataIter,\n","prefixes":["v3","18/18"]}