{"id":21145,"url":"https://patchwork.libcamera.org/api/1.1/patches/21145/?format=json","web_url":"https://patchwork.libcamera.org/patch/21145/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240902154212.1281257-15-mzamazal@redhat.com>","date":"2024-09-02T15:42:07","name":"[v3,14/18] libcamera: libcamera: Add missing includes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4e597932ce0e7a39dd6531b921777d3b68817b45","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21145/mbox/","series":[{"id":4556,"url":"https://patchwork.libcamera.org/api/1.1/series/4556/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4556","date":"2024-09-02T15:41:53","name":"Remove unused includes","version":3,"mbox":"https://patchwork.libcamera.org/series/4556/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21145/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21145/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50516C3259\n\tfor ;\n\tMon, 2 Sep 2024 15:43:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1414634F8;\n\tMon, 2 Sep 2024 17:43:04 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A7AD634EB\n\tfor ;\n\tMon, 2 Sep 2024 17:43:03 +0200 (CEST)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-22-If8--m4lNGyTr7dZCJMy_A-1;\n\tMon, 02 Sep 2024 11:42:59 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 266401955BF2; Mon, 2 Sep 2024 15:42:57 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BE8FB1955DD6; Mon, 2 Sep 2024 15:42:55 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cUz+dNAa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291782;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tjqv2GmcYEha/UEcqHAOmxD2Yt6ZQXMAsCa6+mVhSjY=;\n\tb=cUz+dNAaNedCc9XkkULKCZBYRKdd0BNO+MsTPchjMJz/OYOHNs3cTK/wH8aZDGMY4BuAB/\n\ttDrhdrs8zO929HmFPPSX148swNUdrh6EbqBGSWdOBhNlKKrwQJc+S5SjekyZ4h73UPfGIv\n\tMiwHPG2pKz74iaPdGo1X2+vPCV+jYgA=","X-MC-Unique":"If8--m4lNGyTr7dZCJMy_A-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","Subject":"[PATCH v3 14/18] libcamera: libcamera: Add missing includes","Date":"Mon, 2 Sep 2024 17:42:07 +0200","Message-ID":"<20240902154212.1281257-15-mzamazal@redhat.com>","In-Reply-To":"<20240902154212.1281257-1-mzamazal@redhat.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Let's add direct includes for classes currently included indirectly,\nthrough other header files.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/base/event_dispatcher_poll.cpp | 1 +\n src/libcamera/camera.cpp | 5 +++++\n src/libcamera/formats.cpp | 2 ++\n src/libcamera/ipa_data_serializer.cpp | 2 ++\n src/libcamera/stream.cpp | 3 +++\n 5 files changed, 13 insertions(+)","diff":"diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\nindex 194d7bd2..52bfb34e 100644\n--- a/src/libcamera/base/event_dispatcher_poll.cpp\n+++ b/src/libcamera/base/event_dispatcher_poll.cpp\n@@ -13,6 +13,7 @@\n #include \n #include \n #include \n+#include \n \n #include \n #include \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 9d1ae696..a86f552a 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -9,6 +9,11 @@\n \n #include \n #include \n+#include \n+#include \n+#include \n+#include \n+#include \n \n #include \n #include \ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 3ee89590..dbefb094 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -7,6 +7,8 @@\n \n #include \"libcamera/internal/formats.h\"\n \n+#include \n+\n #include \n #include \n \ndiff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp\nindex 3e9bef08..f6dd7e6f 100644\n--- a/src/libcamera/ipa_data_serializer.cpp\n+++ b/src/libcamera/ipa_data_serializer.cpp\n@@ -11,6 +11,8 @@\n \n #include \n \n+#include \"libcamera/internal/byte_stream_buffer.h\"\n+\n /**\n * \\file ipa_data_serializer.h\n * \\brief IPA Data Serializer\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex e70688f6..33018ec1 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -10,6 +10,9 @@\n #include \n #include \n #include \n+#include \n+#include \n+#include \n \n #include \n \n","prefixes":["v3","14/18"]}